Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Add input length validation to prevent potential panic** The `RequiredGas` method looks good overall, but it's missing a check for the input length before slicing. T...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Reorganize imports for better readability** The current import statements mix standard library, third-party, and local packages. Consider reorganizing ...
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 3** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>precompiles/act/act.go (3)</summary><blockquote> `18-2...
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 3** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>precompiles/act/act.go (3)</summary><blockquote> `18-2...
backsapc pushed 1 commit to feature/precompile-x/822-act warden-protocol/wardenprotocol
- Update precompiles/act/act.go Co-authored-by: Antonio Pitasi <[email protected]> e6e161a
Pitasi created a review comment on a pull request on warden-protocol/wardenprotocol
https://github.com/evmos/evmos/blob/main/precompiles/staking/staking.go#L97
Pitasi created a review comment on a pull request on warden-protocol/wardenprotocol
let's just keep `act`, which is the actual name of the module/precompile ```suggestion return ctx.Logger().With("evm extension", "act") ```
Pitasi created a review comment on a pull request on warden-protocol/wardenprotocol
i think we can shorten this and make it more readable: ```suggestion switch method { case CheckActionMethod, NewTemplateMethod, RevokeActionMethod, UpdateTemplateMethod, VoteForA...
Pitasi created a review comment on a pull request on warden-protocol/wardenprotocol
```suggestion if err := p.AddJournalEntries(stateDB, snapshot); err != nil { return nil, err } ``` i see this in the `staking` precompile from evmos, not sure what it does. Do we need it?
Pitasi created a review comment on a pull request on warden-protocol/wardenprotocol
do we need this commit here? i don't see it in the `staking` precompile from evmos, for example
Pitasi created a review comment on a pull request on warden-protocol/wardenprotocol
```suggestion p.SetAddress(p.Address()) ``` I don't know exactly how and when this is used inside evmos code, but we should set it, just in case.
Pitasi created a review comment on a pull request on warden-protocol/wardenprotocol
```suggestion // NOTE: This check avoid panicking when trying to decode the method ID if len(input) < 4 { return 0 } methodID := input[:4] ```
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
> [!CAUTION] > Inline review comments failed to post <details> <summary>🛑 Comments failed to post (80)</summary><blockquote> <details> <summary>tests/framework/exec/warden_cli.go (2)</summary><bl...
mn13 pushed 1 commit to feature/precompile-x/822-act warden-protocol/wardenprotocol
- update changelog 57b1de4
backsapc pushed 1 commit to feature/precompile-x/822-act warden-protocol/wardenprotocol
- Fixed x/act tests 004bc10
mn13 pushed 1 commit to feature/precompile-x/822-act warden-protocol/wardenprotocol
- register missed warden events daf77d4
mn13 pushed 1 commit to feature/precompile-x/822-act warden-protocol/wardenprotocol
- uniform event emit d333fdd