Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
tsuliwaensis created a comment on a pull request on ungoogled-software/ungoogled-chromium
> Ok, I just added `__firstlineno__` to the patch as well. Hopefully those are the only ones needed. I am able to successfully run the clone script. Thank you so much!! So now do I copy the ...
PF4Public created a comment on a pull request on ungoogled-software/ungoogled-chromium
> So just to make sure, we're testing if `Sinhalese (si)` (and similar disabled by default locales) is enabled after building with this patch? Exactly.
Cubik65536 created a comment on a pull request on ungoogled-software/ungoogled-chromium
So just to make sure, we're testing if `Sinhalese (si)` is enabled after building with this patch?
clickot created a comment on a pull request on ungoogled-software/ungoogled-chromium
@Ahrotahn I eventually understood what happend to my build concerning the missing `node_modules.tar.gz` to prune: The `fetch-chromium-release` script from archlinux chromium packaging that I tried...
clickot created a comment on a pull request on ungoogled-software/ungoogled-chromium
> Would it then make sense to keep listing all of the files with debug flag? good idea, i'll add that line
PF4Public created a comment on a pull request on ungoogled-software/ungoogled-chromium
Would it then make sense to keep listing all of the files with debug flag? > but nonetheless it might be useful in future cases :-) absolutely! the original idea was even improved :)
clickot created a comment on a pull request on ungoogled-software/ungoogled-chromium
done as requested :) btw: after @Ahrotahn s question in #3069 i noticed that the node_modules.tar.gz file exists after runing the clone script on it's own. so i restarted my build from scratch wit...
PF4Public created a comment on an issue on ungoogled-software/ungoogled-chromium
Additional locales could be enabled by https://github.com/ungoogled-software/ungoogled-chromium/pull/3072
PF4Public opened a pull request on ungoogled-software/ungoogled-chromium
Enable extra locales not normally shipped with Chromium on desktop
Google does not ship some of the locales on desktop by default, we can fix that :) Tested on Linux:  It...
PF4Public created a branch on ungoogled-software/ungoogled-chromium
locales - Google Chromium, sans integration with Google
PF4Public created a comment on a pull request on ungoogled-software/ungoogled-chromium
> Maybe we could instead list the first half-dozen files with a following message saying something like "plus X more files" if there's more than that. That is a good idea! @clickot Would you be ...
Ahrotahn created a comment on a pull request on ungoogled-software/ungoogled-chromium
@PF4Public My main concern at the time was there were 76 files that would be listed. When there are a lot files that will be listed you can end up in a situation where that list is longer than...
clickot created a comment on a pull request on ungoogled-software/ungoogled-chromium
i don't understand what cirrus is complaining about the code formatting, original and reformatted code looks equal to me... @PF4Public i'll double check if this PR is really needed
PF4Public created a comment on a pull request on ungoogled-software/ungoogled-chromium
;) https://github.com/ungoogled-software/ungoogled-chromium/pull/2954#issuecomment-2246230907 https://github.com/ungoogled-software/ungoogled-chromium/pull/2954#issuecomment-2246666744
Ahrotahn created a comment on a pull request on ungoogled-software/ungoogled-chromium
Ok, I just added `__firstlineno__` to the patch as well. Hopefully those are the only ones needed.
tsuliwaensis created a comment on a pull request on ungoogled-software/ungoogled-chromium
> @tsuliwaensis Check the patch again to see if that change is still there. If you're using it as part of a build script rather than running it manually then it might be getting overwritten in the ...
Ahrotahn created a comment on a pull request on ungoogled-software/ungoogled-chromium
@tsuliwaensis Check the patch again to see if that change is still there. If you're using it as part of a build script rather than running it manually then it might be getting overwritten in the p...
clickot opened a pull request on ungoogled-software/ungoogled-chromium
in case of missing files, log their paths together with the error mesage to ease fixing this
in case of missing files, log their paths together with the error message to ease fixing this. Until now these paths were only logged when debug level is enabled.
tsuliwaensis created a comment on a pull request on ungoogled-software/ungoogled-chromium
@Ahrotahn I appended your code block to `utils/depot_tools.patch`, but it still ended with the same error.
Ahrotahn created a comment on a pull request on ungoogled-software/ungoogled-chromium
@tsuliwaensis See if appending this to the end of `utils/depot_tools.patch` solves that issue (the whitespace is important): ```diff @@ -131,6 +131,20 @@ with open(gsutil_flag, 'w')...
clickot created a comment on a pull request on ungoogled-software/ungoogled-chromium
@tsuliwaensis the clone script ran fine for me; later after cloning the build failed because of the missing file to prune. So i don't know what the error causes that you are facing