Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
chris-ashe pushed 1 commit to update_contributing.md_for_namespace ukaea/PROCESS
- Update coding standards and documentation guidelines - Adjusted the maximum line length to 79 characters, following ... c8aec2f
chris-ashe created a review comment on a pull request on ukaea/PROCESS
It is a variant of the Google docstring style, though with some additions as we cite papers etc. I will add this note and also a possible extension
chris-ashe created a review comment on a pull request on ukaea/PROCESS
Good point, I think for this case the majority of f-values have the `f` prefix without the underscore. There is currently quite a mish mash of fractional variables and f-values. Though hopefully so...
chris-ashe created a review comment on a pull request on ukaea/PROCESS
This is what I wanted to know about for the Fortran and how we may be doing it differently. For PEP 8 it is: "Limit all lines to a maximum of 79 characters." "For flowing long blocks of text...
codecov-commenter created a comment on a pull request on ukaea/PROCESS
## [Codecov](https://app.codecov.io/gh/ukaea/PROCESS/pull/3364?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ukaea) Repo...
ajpearcey opened a pull request on ukaea/PROCESS
WIP: Location 1 PF coils don't work if there is no CS
closes #1442
ajpearcey created a branch on ukaea/PROCESS
issue-1442-pf-coil-position-error - PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.
jonmaddock created a review comment on a pull request on ukaea/PROCESS
I believe this is a modified version of the numpy (or is it Google?) docstring format; currently we use the sphinx/reStructuredText one. I'd be keen to use one format, and then convert using a tool...
jonmaddock created a review comment on a pull request on ukaea/PROCESS
What about f-values, which also follow this pattern (at the moment)?
jonmaddock created a review comment on a pull request on ukaea/PROCESS
Could you clarify this? There are current cases (and legitimate future ones) where defining a switch as one value means that others are ignored or are invalid. Perhaps something could be stated abo...
jonmaddock created a review comment on a pull request on ukaea/PROCESS
Could you state what the line length limit is, and maybe provide an example?
jonmaddock created a review on a pull request on ukaea/PROCESS
Thanks for doing this Chris, I appreciate it. Some minor clarifications please.
jonmaddock created a review on a pull request on ukaea/PROCESS
Thanks for doing this Chris, I appreciate it. Some minor clarifications please.
timothy-nunn pushed 1 commit to main ukaea/PROCESS
- Use different GitHub API with greater file number limit (#3362) cc4dd50
timothy-nunn closed a pull request on ukaea/PROCESS
Use different GitHub API with greater file number limit
The current regression test uses a GitHub API with a limit of 1000 files... the tracking repo now has more than that. Uses the trees API instead.
timothy-nunn opened an issue on ukaea/PROCESS
Permanent solution for tracking/testing assets
# Introduction 1. A PR is merged into `main`. 2. The CI system runs all of the regression input files and produces several MFiles. From these MFiles, it extracts key variables to be 'tracked'. 3...
chris-ashe pushed 4 commits to 3260-update-the-fusion-reactions-section-of-the-plasma-docs-to-full-account-for-all-models-and-details ukaea/PROCESS
timothy-nunn pushed 1 commit to regression-test-file-limit ukaea/PROCESS
- Use different GitHub API with greater file number limit 1914d60
timothy-nunn created a comment on a pull request on ukaea/PROCESS
On main the regression tests show: ``` ============= 4 passed, 2 skipped, 7 warnings in 271.66s (0:04:31) ============= ``` On this branch, the regression tests show: ``` ==================...
timothy-nunn opened a pull request on ukaea/PROCESS
Use different GitHub API with greater file number limit
The current regression test uses a GitHub API with a limit of 1000 files... the tracking repo now has more than that. Uses the trees API instead.
timothy-nunn created a branch on ukaea/PROCESS
regression-test-file-limit - PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.
timothy-nunn created a branch on ukaea/PROCESS
1591-convert-ifef90-to-python - PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.
timothy-nunn pushed 1 commit to 3183-convert-neoclassics_modulef90-to-python ukaea/PROCESS
- Remove const_and_precision.f90 7ef0925
timothy-nunn pushed 4 commits to 3183-convert-neoclassics_modulef90-to-python ukaea/PROCESS
- Install instructions have incorrect python version (#3356) * Updated to say python 3.8 - 3.11 * Updated installat... f6af42a
- Added else to account for divlife_cal not being set correctly (#3359) a6008b0
- Add IFE regression test (#3346) 096f36b
- Convert neoclassics_module.f90 to Python * Remove unused neoclassic routine * Add tests for neoclassics module * Con... e95cf99
codecov-commenter created a comment on a pull request on ukaea/PROCESS
## [Codecov](https://app.codecov.io/gh/ukaea/PROCESS/pull/3360?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ukaea) Repo...
timothy-nunn pushed 1 commit to 3183-convert-neoclassics_modulef90-to-python ukaea/PROCESS
- Convert neoclassics_module.f90 to Python * Remove unused neoclassic routine * Add tests for neoclassics module * Con... c98589b
codecov-commenter created a comment on a pull request on ukaea/PROCESS
## [Codecov](https://app.codecov.io/gh/ukaea/PROCESS/pull/3361?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ukaea) Repo...