Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
SamFayolle created a review comment on a pull request on tudat-team/tudatpy-examples
Added a comment there that should hopefully explain it. Basically it is because each odf file might spans over more than one day, which for the latest one means that it can exceed the time interval...
SamFayolle created a review comment on a pull request on tudat-team/tudatpy-examples
indeed, that was a final check of the plotting on my side, and I forgot to uncomment it afterwards. sorry!
DominicDirkx created a comment on a pull request on tudat-team/tudatpy-examples
I went through the example code, and it looks really good! I haven't tried to run it (but I think a part is commented out at the end that is crucial to run it?) I added a bunch of small comments, m...
DominicDirkx created a review comment on a pull request on tudat-team/tudatpy-examples
This block of code should not be commented right?
DominicDirkx created a review comment on a pull request on tudat-team/tudatpy-examples
Add a comment explaining what this is
DominicDirkx created a review comment on a pull request on tudat-team/tudatpy-examples
I think it's better to move this command earlier, unless you need all the antenna stuff for it (but I don't think you do, right?)
DominicDirkx created a review comment on a pull request on tudat-team/tudatpy-examples
Add comment stating that this is to set the antenna transmission frequencies
DominicDirkx created a review comment on a pull request on tudat-team/tudatpy-examples
Why is a spice ephemeris directly not an option? Is it due to the com_position offset?
DominicDirkx created a review comment on a pull request on tudat-team/tudatpy-examples
The comment and variable name are a little confusing. What does this variable exactly contain?
DominicDirkx created a review comment on a pull request on tudat-team/tudatpy-examples
Why is this step necessary? All observations that cover the unsupported time period should have been filtered out already right? Not saying it needs to go, but it's important to explain why it's here
DominicDirkx created a review comment on a pull request on tudat-team/tudatpy-examples
Could you add a comment explaining where the 1 hour buffer comes from? (same in line 222)
DominicDirkx created a review comment on a pull request on tudat-team/tudatpy-examples
Nice showcase of the filtering :)
DominicDirkx created a review comment on a pull request on tudat-team/tudatpy-examples
Are the time inputs still needed? I think we can remove these now right (?)
DominicDirkx created a review comment on a pull request on tudat-team/tudatpy-examples
What does/should this do?