etan-status created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 9:33pm

```suggestion if (counter < 0) or (counter > high(durations)): ``` or >=

View on GitHub

etan-status created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 9:33pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 7:14pm

This code was removed and merged already into `unstable`.

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 7:14pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 7:08pm

Fixed in https://github.com/status-im/nimbus-eth2/pull/6515/commits/d71139db1343167811d0f2feefe3dd453f6d1d99

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 7:08pm

View on GitHub

cheatfate pushed 1 commit to hybrid-sync status-im/nimbus-eth2

October 21, 2024 7:05pm

• Address review comments part 5 and fix tests. d71139d

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 7:03pm

Fixed in https://github.com/status-im/nimbus-eth2/commit/646bef4e79ceed8a1d41bb46fb90729e60302bbf

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 7:03pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 7:03pm

Fixed in https://github.com/status-im/nimbus-eth2/commit/646bef4e79ceed8a1d41bb46fb90729e60302bbf

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 7:03pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 7:03pm

Fixed in https://github.com/status-im/nimbus-eth2/commit/646bef4e79ceed8a1d41bb46fb90729e60302bbf

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 7:03pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 5:46pm

Fixed in https://github.com/status-im/nimbus-eth2/pull/6515/commits/646bef4e79ceed8a1d41bb46fb90729e60302bbf

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 5:46pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 5:46pm

Fixed in https://github.com/status-im/nimbus-eth2/pull/6515/commits/646bef4e79ceed8a1d41bb46fb90729e60302bbf

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 5:46pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 5:45pm

Fixed in https://github.com/status-im/nimbus-eth2/pull/6515/commits/646bef4e79ceed8a1d41bb46fb90729e60302bbf

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 5:45pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 5:45pm

Fixed in https://github.com/status-im/nimbus-eth2/pull/6515/commits/646bef4e79ceed8a1d41bb46fb90729e60302bbf

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 5:45pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 5:44pm

Fixed in https://github.com/status-im/nimbus-eth2/pull/6515/commits/646bef4e79ceed8a1d41bb46fb90729e60302bbf

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 5:44pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 5:44pm

Fixed in https://github.com/status-im/nimbus-eth2/pull/6515/commits/646bef4e79ceed8a1d41bb46fb90729e60302bbf

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 5:44pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 5:44pm

Fixed in https://github.com/status-im/nimbus-eth2/pull/6515/commits/646bef4e79ceed8a1d41bb46fb90729e60302bbf

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 5:44pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 5:43pm

Fixed in https://github.com/status-im/nimbus-eth2/pull/6515/commits/646bef4e79ceed8a1d41bb46fb90729e60302bbf

View on GitHub

cheatfate created a review on a pull request on status-im/nimbus-eth2

October 21, 2024 5:43pm

View on GitHub

cheatfate created a review comment on a pull request on status-im/nimbus-eth2

October 21, 2024 5:43pm

Fixed in https://github.com/status-im/nimbus-eth2/pull/6515/commits/646bef4e79ceed8a1d41bb46fb90729e60302bbf

View on GitHub