Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
davidjumani created a review comment on a pull request on solo-io/gloo
There are tests but none that test this particular scenario. I'm willing to add it although it might not be of much value since it would still follow the sad path that is being tested here
github-actions[bot] created a comment on a pull request on solo-io/gloo
Visit the preview URL for this PR (updated for commit 0e77c7d): [https://gloo-edge--pr10238-sh-split-options-api-g8zgf8xs.web.app](https://gloo-edge--pr10238-sh-split-options-api-g8zgf8xs.web.app)...
yuval-k pushed 1 commit to yuval-k/endpoints-prep solo-io/gloo
- set md on sk objects; disable liveness probe, so we can debug without gloo dying. d1a7560
sam-heilbron created a review on a pull request on solo-io/gloo
I think any PR that fixes a segfault in the control plane must have sufficient testing to prove that it will not regress. I think we need to have an e2e test to adequately prove this out
sam-heilbron created a review comment on a pull request on solo-io/gloo
nit: I think it could be useful to clarify in the function comment under what circumstances this function returns an error, and the impact on the control plane when one occurs
sam-heilbron created a review comment on a pull request on solo-io/gloo
I like this test! I would argue it would be valuable to test not just that we error out, but that _other_ reports are correctly written. That is an important functional behavior we need to maintain
sam-heilbron created a review comment on a pull request on solo-io/gloo
nit: Is this implicitly done by the assertion in the next line? (Should we just remove this)
sam-heilbron created a review on a pull request on solo-io/gloo
This issue occurs because we have code to implement status reporting on these objects, is that correct? If so, that means that we _could be_ susceptible to this when we implement status reporting o...
sam-heilbron created a review on a pull request on solo-io/gloo
This issue occurs because we have code to implement status reporting on these objects, is that correct? If so, that means that we _could be_ susceptible to this when we implement status reporting o...
jbohanon pushed 1 commit to jbohanon/test-summaries-3 solo-io/gloo
- only send message if failure occurred 2e0ca01
sam-heilbron opened a draft pull request on solo-io/gloo
[WIP] gloo/api/options.proto: split options to separate files
# Description <!-- Please include a high level summary of the changes. This bug fixes ... \ This new feature can be used to ... _Fill out any of the following sections that are relevant a...
sam-heilbron created a branch on solo-io/gloo
sh/split-options-apis - The Feature-rich, Kubernetes-native, Next-Generation API Gateway Built on Envoy
github-actions[bot] created a comment on a pull request on solo-io/gloo
Visit the preview URL for this PR (updated for commit 8c4c13d): [https://gloo-edge--pr10237-eitanya-ai-prompt-gu-u9ju74af.web.app](https://gloo-edge--pr10237-eitanya-ai-prompt-gu-u9ju74af.web.app)...
solo-changelog-bot[bot] created a comment on a pull request on solo-io/gloo
Issues linked to changelog: https://github.com/solo-io/solo-projects/issues/7073
EItanya opened a draft pull request on solo-io/gloo
Eitanya/ai prompt guard regex additions
# Description <!-- Please include a high level summary of the changes. This bug fixes ... \ This new feature can be used to ... _Fill out any of the following sections that are relevant a...
EItanya pushed 9 commits to eitanya/ai-prompt-guard-regex-additions solo-io/gloo
- KRT for GG (Part 1) (#10193) introduce krt-based syncer for kube gw proxies Co-authored-by: Steven Landow <steven... 94d02de
- Fixing issue with Tilt setup and a 'missing' file (#10231) a01d3f4
- OPA auth API docs update (#10227) Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.norepl... 761db93
- Install script - don't pull amd64 bin on arm64 (#10233) Signed-off-by: Benjamin Leggett <[email protected]> cbc3c7d
- add stopwatches for translator and envoy syncer (#10229) Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bull... ea468b6
- [Documenation] Update istio version support (#10234) Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldoze... c003a92
- code-gen 9704d66
- Merge branch 'main' of https://github.com/solo-io/gloo into eitanya/ai-prompt-guard-regex-additions 41f3817
- changelog 8c4c13d
nfuden created a comment on an issue on solo-io/gloo
Blocks fronting a factorio 2.0 server with gateway see this reference implementation of a k8s factorio setup https://github.com/SQLJames/factorio-server-charts/blob/f60af0b1f7c1f4e47f3c42977f0d77c...
npolshakova created a review comment on a pull request on solo-io/gloo
This route option has a target ref: https://github.com/solo-io/gloo/blob/5ba215860f8f82cef28c6666ccbfc7ff19faf5b4/projects/gateway2/translator/plugins/routeoptions/route_options_plugin_test.go#L776...
npolshakova created a review comment on a pull request on solo-io/gloo
[nit] Instead of inlining we could make a public error here to make it easier to reuse in the tests.