Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
winder created a review comment on a pull request on smartcontractkit/chainlink-ccip
Which one of these is the fix? If you were to remove the unused fields are the others still returned?
winder created a review comment on a pull request on smartcontractkit/chainlink-ccip
Check for zero addresses as well? The discovery processor has this helper: ``` // isZero returns true if data is nil or all zeros, otherwise returns false. func isZero(data []byte) bool { for ...
winder created a review comment on a pull request on smartcontractkit/chainlink-ccip
nit: if you return rather than logging this might be helpful for other functions as well. ```suggestion func isValidAddress(address []byte, contractName string, chain cciptypes.ChainSelector) (bo...
github-actions[bot] created a comment on a pull request on smartcontractkit/chainlink-ccip
| Metric | `native-token` | `main` | |--|--|--| | **Coverage** | 72.5% | 72.5% |
asoliman92 created a review comment on a pull request on smartcontractkit/chainlink-ccip
I agree with @mateusz-sekara here. If this error was present I could've figured out somethings earlier.
asoliman92 created a review comment on a pull request on smartcontractkit/chainlink-ccip
> You're getting the dest chain config from each onramp Yes > Then we should always use r.destChain All dest configs have same router address (or maybe test address). Why should it be alwa...
mateusz-sekara created a review comment on a pull request on smartcontractkit/chainlink-ccip
Hmm, I would say it depends. If this is something that should never happen or happens because of the wrong configuration then error/critical is easier to spot in the logs. If this is a regular chec...
asoliman92 created a review comment on a pull request on smartcontractkit/chainlink-ccip
I wrote it and deleted it locally 😁. re-adding them 👍
makramkd created a review comment on a pull request on smartcontractkit/chainlink-ccip
Wait, this comment doesn't make sense to me. You're getting the dest chain config from each onramp, correct? Then we should always use `r.destChain`. I believe this was the fix I made here but elec...
makramkd created a review comment on a pull request on smartcontractkit/chainlink-ccip
Don't use error, it will spam the logs with a big stack trace. Warn here makes more sense to me
makramkd created a review comment on a pull request on smartcontractkit/chainlink-ccip
Some comments on why this is structured this way would be useful
makramkd created a review comment on a pull request on smartcontractkit/chainlink-ccip
Please fix the error message below which is incorrect ```golang return fmt.Errorf("failed to get onramp dest chain config: %w", err) ```
github-actions[bot] created a comment on a pull request on smartcontractkit/chainlink-ccip
| Metric | `native-token` | `main` | |--|--|--| | **Coverage** | 72.5% | 72.4% |
github-actions[bot] created a comment on a pull request on smartcontractkit/chainlink-ccip
| Metric | `native-token` | `main` | |--|--|--| | **Coverage** | 72.5% | 72.5% |
github-actions[bot] created a comment on a pull request on smartcontractkit/chainlink-ccip
| Metric | `native-token` | `main` | |--|--|--| | **Coverage** | 72.5% | 72.5% |
asoliman92 pushed 1 commit to native-token smartcontractkit/chainlink-ccip
- use isValidAddress 3d3bd2d