Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
winder pushed 1 commit to will/get-all-source smartcontractkit/chainlink-ccip
- Remove deprecated parameter. 564a3ee
winder created a review comment on a pull request on smartcontractkit/chainlink-ccip
I believe it's actually the json tags in that example which aren't needed. When a tag isn't provided the field name is used.
github-actions[bot] created a comment on a pull request on smartcontractkit/chainlink-ccip
| Metric | `fix-contract-discovery` | `main` | |--|--|--| | **Coverage** | 72.5% | 72.5% |
asoliman92 pushed 2 commits to fix-contract-discovery smartcontractkit/chainlink-ccip
github-actions[bot] created a comment on a pull request on smartcontractkit/chainlink-ccip
| Metric | `dk/fix-rmn-report-version` | `main` | |--|--|--| | **Coverage** | 72.6% | 72.6% |
asoliman92 created a review comment on a pull request on smartcontractkit/chainlink-ccip
I believe we don't need to use `mapstructure` here. check this [example](https://github.com/smartcontractkit/chainlink-ccip/blob/ad2992ddf2377fe55c65e1aca9cb03c1c8cd8b2a/internal/reader/home_chain....
asoliman92 created a review comment on a pull request on smartcontractkit/chainlink-ccip
Why not remove it in this PR? No external calls for this AFAIK.
mateusz-sekara created a review on a pull request on smartcontractkit/chainlink-ccip
Can we have a test covering this fix? I mean failing before applying your fixes
github-actions[bot] created a comment on a pull request on smartcontractkit/chainlink-ccip
| Metric | `will/get-all-source` | `main` | |--|--|--| | **Coverage** | 72.6% | 72.5% |
winder pushed 8 commits to will/get-all-source smartcontractkit/chainlink-ccip
- Exec plugin: Compute message fee in USD (#217) Adds a real implementation for the MessageFeeUSD18Calculator iface th... f93834f
- RMN home reader plumbing (#231) 2c5c9ae
- bump (#238) c516619
- Misc. fixes (#229) * Fix bug: Nodes that didn't support feed chain were not participating in the observation at all.... 9948748
- bump (#241) c4c6665
- RMN related fixes and more logs (#235) - fix a race condition - add more logs - fix stream name 753d327
- Migrate ccipocr3 package. (#240) Deprecating types in chainlink-common. 5b5f448
- Merge branch 'main' into will/get-all-source 7a12dfd
github-actions[bot] created a comment on a pull request on smartcontractkit/chainlink-ccip
| Metric | `fix-contract-discovery` | `main` | |--|--|--| | **Coverage** | 72.5% | 72.6% |
asoliman92 created a review comment on a pull request on smartcontractkit/chainlink-ccip
I don't "need" to, it felt more consistent to use the same `facade` everywhere though.
asoliman92 pushed 1 commit to fix-contract-discovery smartcontractkit/chainlink-ccip
- Address comments ad2992d
winder created a review comment on a pull request on smartcontractkit/chainlink-ccip
I'm surprised that you need to switch from `p.contractReaders` to `readers`. Is that really required? We can move the facade mapping to `NewPluginFactory` and avoid using the actual ContractRead...
asoliman92 created a review comment on a pull request on smartcontractkit/chainlink-ccip
Yes, it's covered by the nil check above, doing extra won't hurt though.
makramkd created a review comment on a pull request on smartcontractkit/chainlink-ccip
Can be nil, is this covered by the nil check above?
makramkd created a review comment on a pull request on smartcontractkit/chainlink-ccip
This can be nil, need to do a nil check somewhere
github-actions[bot] created a comment on a pull request on smartcontractkit/chainlink-ccip
| Metric | `fix-contract-discovery` | `main` | |--|--|--| | **Coverage** | 72.6% | 72.6% |