Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
grahamia created a review comment on a pull request on sky-uk/kfp-operator
I see webhook was wrong before but this shouldn't be inside statusFeedback, should be part of a triggers section or something and default again should be it isn't deployed.
grahamia created a review comment on a pull request on sky-uk/kfp-operator
As config comment think this should be [] for default install, no event feedback by default
grahamia created a review comment on a pull request on sky-uk/kfp-operator
I think this should be [] still for a default install
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- fix log message templating a3e2803
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- move around makefile commands 4e68b62
grahamia created a comment on an issue on sky-uk/kfp-operator
This is superseded by #376 which will expose all provider events as metrics
grahamia closed an issue on sky-uk/kfp-operator
Expose model training metrics
### Overview The run-completion eventsource server should expose Prometheus-scrapable metrics for when model training has finished.
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- Apply suggestions from pr c5e95dc
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- Apply suggestions from pr 76ea65d
aidandunlop pushed 1 commit to 364-schedule-starttime-endtime sky-uk/kfp-operator
- add conversion code for runconfigurations 310aebb
chr12c created a review comment on a pull request on sky-uk/kfp-operator
You can define separate error types and then have them implement the Error() method. Then the caller can do a case switch on the error
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- Apply suggestions from pr 3332e2e
TobyPinfold created a review comment on a pull request on sky-uk/kfp-operator
We haven't used `domain` across this repo at all, it wouldn't make sense to just start using it here. re: ArtifactsConverter and StatusConverter, they were initially private, they are now privat...
TobyPinfold created a review comment on a pull request on sky-uk/kfp-operator
If we return just an Error, theres no way of determining the cause of the error from the callers side. Given we want to return different responses wether it was a connection error or a marshalling ...
chr12c pushed 1 commit to 364-schedule-starttime-endtime sky-uk/kfp-operator
- modify schedules to add startTime and endTime fields f45fc27
chr12c pushed 1 commit to 364-schedule-starttime-endtime sky-uk/kfp-operator
- modify schedules to add startTime and endTime fields 09de5e7
chr12c created a review comment on a pull request on sky-uk/kfp-operator
this function name doesn't really fit in with the `ArtifactsConverter` and `StatusConverter` (or the other way round if you prefer).
chr12c created a review comment on a pull request on sky-uk/kfp-operator
I think the term "domain" makes more sense than "comon"
chr12c created a review comment on a pull request on sky-uk/kfp-operator
```suggestion When("given an environment variable", func() { It("correctly overrides the config value", func() { ```
chr12c pushed 1 commit to 364-schedule-starttime-endtime sky-uk/kfp-operator
- unit test kfp provider `createAPICronSchedule` helper function. 961ffa8
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- use switch statement d6e2e8b
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- Update Protobuf to use Enum and client + server implementations ecf3bda