Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- remove request.json 96beca7
chr12c created a review comment on a pull request on sky-uk/kfp-operator
ok. But given the other [comment](https://github.com/sky-uk/kfp-operator/pull/377#discussion_r1808797425), I guess this doesn't really matter. Can revisit if it does.
TobyPinfold created a review comment on a pull request on sky-uk/kfp-operator
should probably have a unit test for publishHandler for coverage even though its simple, will add
TobyPinfold created a review comment on a pull request on sky-uk/kfp-operator
status is of `type RunCompletionStatus string` type alias means we need to convert it back to its primitive `string` type to satisfy the compiler. `Artifact.Name` is already a `string` as be...
chr12c created a review comment on a pull request on sky-uk/kfp-operator
```suggestion It("returns no error when event data is converted to proto runcompletion event", func() { ```
chr12c created a review comment on a pull request on sky-uk/kfp-operator
we really going to use a string? Is there no exhaustive list of status coming back that we can check against
chr12c created a review comment on a pull request on sky-uk/kfp-operator
I think you can move this into `server_unit_test`
chr12c created a review comment on a pull request on sky-uk/kfp-operator
why is rce treated differently from other strings which don't have what is effectively a string type alias
aidandunlop pushed 5 commits to 364-schedule-starttime-endtime sky-uk/kfp-operator
- Update controller-gen version to v0.12.0 (#379) * Update controller-gen version to v0.12.0 2b32018
- create v1alpha6 CRD version and remove v1alpha2-v1alpha4 67ce57a
- remove v1alpha2,3,4 apis/config 6c45641
- modify schedules to add startTime and endTime fields 9cc4f12
- passed starttime and endtime to vai 64100af
aidandunlop pushed 3 commits to v1alpha6 sky-uk/kfp-operator
aidandunlop pushed 3 commits to 364-schedule-starttime-endtime sky-uk/kfp-operator
aidandunlop pushed 1 commit to 364-schedule-starttime-endtime sky-uk/kfp-operator
- passed starttime and endtime to vai 4f070a6
TobyPinfold pushed 10 commits to 358-implement-nats-event-trigger sky-uk/kfp-operator
- Rework publishing to be via a PublishHandler interface f48e1cf
- Update helm configuration and docker images 4511f8a
- Add nats event server/nats event bus functional test. 9d390be
- Change service name to run-completion-event-trigger 42c9449
- Update sensor datakey for use with new run completion format d7e0093
- Remove unused event source webhook 8d80812
- Remove grpc config for deployment in kustomize 34c124c
- Move helm chart for triggers into statusFeedback eventing loop f5bac78
- Remove triggers from kustomization config 7aa90a9
- Update with suggestions from PR Co-authored-by: chr12c <[email protected]> f427981
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- fix helm 012ded4
TobyPinfold pushed 6 commits to 358-implement-nats-event-trigger sky-uk/kfp-operator
- Update sensor datakey for use with new run completion format 36bb143
- Remove unused event source webhook ecfe813
- Remove grpc config for deployment in kustomize 5de646b
- Move helm chart for triggers into statusFeedback eventing loop d17bdcb
- Remove triggers from kustomization config c0c51f0
- Update with suggestions from PR Co-authored-by: chr12c <[email protected]> 0a659ce
TobyPinfold pushed 16 commits to 358-implement-nats-event-trigger sky-uk/kfp-operator
- Update controller-gen version to v0.12.0 (#379) * Update controller-gen version to v0.12.0 2b32018
- Create event-trigger grpc server 563cd04
- Dockerise event-trigger fbd5fee
- Helm + kustomize setup bafa156
- Replace http webhook client with grpc 055e3e9
- Add to upstream service unit tests b7190a1
- Rework publishing to be via a PublishHandler interface for dependency injection e324f71
- Update helm configuration and docker images 61f9fae
- Add nats event server/nats event bus integration test. 7363481
- Change service name to run-completion-event-trigger 06670d0
- update sensor datakey for use with new run completion format a8c6c97
- remove unused event source webhook ff8496e
- remove grpc config for deployment in kustomize 36e772c
- move helm chart for triggers into statusFeedback eventing loop a1fde1e
- remove triggers from kustomization config a1a0a04
- update with suggestions from PR Co-authored-by: chr12c <[email protected]> ae5cab5
TobyPinfold pushed 1 commit to master sky-uk/kfp-operator
- Update controller-gen version to v0.12.0 (#379) * Update controller-gen version to v0.12.0 2b32018
TobyPinfold closed a pull request on sky-uk/kfp-operator
Update controller-gen version to v0.12.0
links to #358 In order to utilise more recent gRPC libraries we need to upgrade the version of controller-gen used. It currently is using version 0.4.1 which is many years out of date. This...
alexgeorgousis created a review on a pull request on sky-uk/kfp-operator
LFTM (looks fantastic to me)
