Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
aidandunlop pushed 2 commits to 364-schedule-starttime-endtime sky-uk/kfp-operator
aidandunlop pushed 1 commit to v1alpha6 sky-uk/kfp-operator
- create v1alpha6 CRD version and remove v1alpha2-v1alpha4 3051f8b
TobyPinfold pushed 1 commit to Upgrade-controller-gen-v0.12.0 sky-uk/kfp-operator
- fix makefile crd generation 026f521
TobyPinfold pushed 2 commits to 358-implement-nats-event-trigger sky-uk/kfp-operator
- remove triggers from kustomization config 0420c6d
- update with suggestions from PR Co-authored-by: chr12c <[email protected]> 138a097
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- Update triggers/run-completion-event-trigger/README.md Co-authored-by: chr12c <[email protected].... d54be8f
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- Update triggers/run-completion-event-trigger/README.md Co-authored-by: chr12c <[email protected].... 66d8b24
TobyPinfold pushed 1 commit to Upgrade-controller-gen-v0.12.0 sky-uk/kfp-operator
- fix makefile crd generation 812efe7
TobyPinfold pushed 1 commit to Upgrade-controller-gen-v0.12.0 sky-uk/kfp-operator
- fix makefile crd generation e236930
grahamia created a review comment on a pull request on sky-uk/kfp-operator
Makes total sense to me 👍
TobyPinfold created a review comment on a pull request on sky-uk/kfp-operator
I think as the docker-build is a direct call to another makefile definition as opposed to a CLI program it needs to be on the first line
TobyPinfold pushed 1 commit to Upgrade-controller-gen-v0.12.0 sky-uk/kfp-operator
- fix makefile crd generation af8c9dd
chr12c created a review comment on a pull request on sky-uk/kfp-operator
```suggestion Configuration files `config.yaml` must be located in the same location the user is calling the binary from, i.e. `$pwd/.`. ```
chr12c created a review comment on a pull request on sky-uk/kfp-operator
```suggestion Alternatively a `config.yaml` can be located at `/etc/run-completion-event-trigger/config.yaml` to be accessed when the binary is called ```
chr12c created a review comment on a pull request on sky-uk/kfp-operator
```suggestion functional-test: docker-build docker compose up -d ```
TobyPinfold created a review comment on a pull request on sky-uk/kfp-operator
removed `ignoreUnexportedFields=false` as its the default behaviour. In order to upgrade a CRD from v1beta1 to v1 you would need to use the `preserveUnknownFields=true` flag. So reasons why we ...
TobyPinfold pushed 1 commit to Upgrade-controller-gen-v0.12.0 sky-uk/kfp-operator
- remove default CRD option c46f982
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- default behaviour 56684cc
grahamia created a review comment on a pull request on sky-uk/kfp-operator
As discussing directly, this change doesnt seem to matchup
grahamia created a review comment on a pull request on sky-uk/kfp-operator
Assume this comment isnt valid anymore
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- update with suggestions from PR Co-authored-by: chr12c <[email protected]> f9a0bff
TobyPinfold pushed 1 commit to 358-implement-nats-event-trigger sky-uk/kfp-operator
- update with suggestions from PR Co-authored-by: chr12c <[email protected]> ffe518d