Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dasunpubudumal created a review comment on a pull request on sanger/traction-service
Yeah that's correct. But because we have the schemas in RedPanda, and we are _not_ removing them, if we decide to revert back to an older schema, that mean we would have to change this `pacbio.yml`...
dasunpubudumal created a review comment on a pull request on sanger/traction-service
Courtesy of @BenTopping 😄
seenanair created a review comment on a pull request on sanger/traction-service
Ok, it's not a big issue for now, but something to think about in future. I think the dependency with the tests is because we are keeping a stub response at spec/fixtures/volume_tracking_avro_res...
dasunpubudumal created a review comment on a pull request on sanger/traction-service
I'm not entirely sure. The tests are highly coupled with this key. For example, if I remove `avro_schema_version_1`, I would have to change all the tests as well. My understanding of this `yml`...
dasunpubudumal created a review comment on a pull request on sanger/traction-service
I think it's 2. Previously it was 1.
seenanair created a review comment on a pull request on sanger/traction-service
One doubt, Is the latest avro_schema_version is v '2' or '3'?
seenanair created a review comment on a pull request on sanger/traction-service
Do we need to keep this version as only one version will picked up from bunny.yml ?
seenanair created a review comment on a pull request on sanger/traction-service
Oh, Is there a source.container accessor? Good way to get source barcode which avoids checking whether it's a tube or a plate. 👍
dasunpubudumal pushed 1 commit to 1451-y24-370---as-tree-of-life-we-would-like-the-sample-data-in-the-warehouse-when-a-library-is-created-so-that-we-can-track-back-to-the-original-plate-or-tube-barcode-to-make-the-top-up-process-more-efficient sanger/traction-service
- Linting (rubocop) 94f3f3e
dasunpubudumal pushed 1 commit to 1451-y24-370---as-tree-of-life-we-would-like-the-sample-data-in-the-warehouse-when-a-library-is-created-so-that-we-can-track-back-to-the-original-plate-or-tube-barcode-to-make-the-top-up-process-more-efficient sanger/traction-service
- Fixing tests 692c584
dasunpubudumal pushed 1 commit to 1451-y24-370---as-tree-of-life-we-would-like-the-sample-data-in-the-warehouse-when-a-library-is-created-so-that-we-can-track-back-to-the-original-plate-or-tube-barcode-to-make-the-top-up-process-more-efficient sanger/traction-service
- Update app/resources/v1/pacbio/library_resource.rb Co-authored-by: Ben Topping <[email protected]... bb51ac6
BenTopping created a review comment on a pull request on sanger/traction-service
Should the barcode here be the library barcode?
BenTopping created a review comment on a pull request on sanger/traction-service
```suggestion Emq::Publisher.publish([@model.primary_aliquot, *@model.used_aliquots]), ```
BenTopping created a review comment on a pull request on sanger/traction-service
If line 68 was working (using container) I think that is nicer than doing an if check
BenTopping created a review comment on a pull request on sanger/traction-service
Ok, yeah just wanted to double check 👌
dasunpubudumal pushed 1 commit to 1451-y24-370---as-tree-of-life-we-would-like-the-sample-data-in-the-warehouse-when-a-library-is-created-so-that-we-can-track-back-to-the-original-plate-or-tube-barcode-to-make-the-top-up-process-more-efficient sanger/traction-service
- Fixing tests fa6cf84
dasunpubudumal pushed 1 commit to 1451-y24-370---as-tree-of-life-we-would-like-the-sample-data-in-the-warehouse-when-a-library-is-created-so-that-we-can-track-back-to-the-original-plate-or-tube-barcode-to-make-the-top-up-process-more-efficient sanger/traction-service
- Fixing tests 1669ed5
dasunpubudumal pushed 1 commit to 1451-y24-370---as-tree-of-life-we-would-like-the-sample-data-in-the-warehouse-when-a-library-is-created-so-that-we-can-track-back-to-the-original-plate-or-tube-barcode-to-make-the-top-up-process-more-efficient sanger/traction-service
- Fixing tests 63ca5cf
dasunpubudumal created a review comment on a pull request on sanger/traction-service
The requirements say that "he sample should have a source barcode which is the plate or tube barcode" so I assumed the plate or tube barcode would be enough?