Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

pyca/cryptography

reaperhulk pushed 1 commit to main pyca/cryptography
  • Convert the remaining extensions to use Asn1Operation (#12030) 0c76072

View on GitHub

reaperhulk created a review on a pull request on pyca/cryptography

View on GitHub

reaperhulk pushed 1 commit to main pyca/cryptography
  • Convert several additional extensions to use Asn1Operation (#12020) f01ee1d

View on GitHub

reaperhulk created a review on a pull request on pyca/cryptography

View on GitHub

obfusk created a comment on an issue on pyca/cryptography
> For non-X.509 structures that use the same signatures structures, can you give us an example? This would also reduce the need for custom code to create and verify APK signatures -- which use X...

View on GitHub

alex created a comment on an issue on pyca/cryptography
Are there other motivations for this besides the two you listed? In general, working with broken X.509 structures isn't really something we endeavor to support. For non-X.509 structures that ...

View on GitHub

alex created a review comment on a pull request on pyca/cryptography
I would just use Python for this.

View on GitHub

alex created a review on a pull request on pyca/cryptography

View on GitHub

nitneuqr created a review comment on a pull request on pyca/cryptography
Do you have any suggestion of a lib to handle MIME efficiently in rust? For now, I'm thinking about using some Python function. Seems simpler to me.

View on GitHub

nitneuqr created a review on a pull request on pyca/cryptography

View on GitHub

nitneuqr created a review comment on a pull request on pyca/cryptography
Yup! Just saw your other comment, works perfectly!

View on GitHub

nitneuqr created a review on a pull request on pyca/cryptography

View on GitHub

alex created a review comment on a pull request on pyca/cryptography
Ah, whoops, I inverted the logic. The same approach to writing a full loop, instead of the `any()`, that I suggested above should work here.

View on GitHub

alex created a review on a pull request on pyca/cryptography

View on GitHub

nitneuqr created a review comment on a pull request on pyca/cryptography
Thanks! I'll go with this

View on GitHub

nitneuqr created a review on a pull request on pyca/cryptography

View on GitHub

nitneuqr created a review comment on a pull request on pyca/cryptography
That's correct, but doing so, we are not defensively failing if someone passes another PKCS #7 Option to `pkcs7_decrypt`, even if it has no impact. Are we fine with this?

View on GitHub

nitneuqr created a review on a pull request on pyca/cryptography

View on GitHub

alex created a review comment on a pull request on pyca/cryptography
And in this case you can unroll the loop: ``` for opt in options.iter() { if !opt.is_instance(&pkcs7_option_type)? { return Err(...); } }

View on GitHub

alex created a review on a pull request on pyca/cryptography

View on GitHub

alex created a review comment on a pull request on pyca/cryptography
`PanicExceptions` are always considered bugs. FWIW in this case I believe you should be able to use `options.contains(&text_option)?` to get what you want.

View on GitHub

alex created a review on a pull request on pyca/cryptography

View on GitHub

nitneuqr created a review comment on a pull request on pyca/cryptography
So, I've been trying to raise an error on __eq__, which is actually not that simple; but manage to do so, will push something in the evening (Europe time). Can you give me more details as to why an...

View on GitHub

nitneuqr created a review on a pull request on pyca/cryptography

View on GitHub

reaperhulk deleted a branch pyca/cryptography

alex-patch-1

reaperhulk pushed 1 commit to main pyca/cryptography
  • Build manylinux 2.34 images (#12029) 7124ffb

View on GitHub

reaperhulk closed a pull request on pyca/cryptography
Build manylinux 2.34 images
Load more