Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
cpsievert pushed 1 commit to markdown-stream-component posit-dev/py-shiny
- Remove the .ui() entirely from shiny.ui.MarkdownStream 95f271a
cpsievert pushed 1 commit to markdown-stream-component posit-dev/py-shiny
- Take another pass at polishing docstrings 96d6db0
cpsievert created a review comment on a pull request on posit-dev/py-shiny
I get where you're coming from. I think it could technically work since there's not currently any important state management going on, but it makes me feel uneasy that it would handcuff future desi...
cpsievert created a review comment on a pull request on posit-dev/py-shiny
> but we should also have content_type as an argument in stream() I agree, but unfortunately it wouldn't be support that combined with `.stream(clear=False)` since you could end up with a mix of...
cpsievert created a review comment on a pull request on posit-dev/py-shiny
Done in [d091ebd](https://github.com/posit-dev/py-shiny/pull/1782/commits/d091ebdedb97b6f222f8284c5ac05695d1942b42)
cpsievert created a review comment on a pull request on posit-dev/py-shiny
Addressed in [d091ebd](https://github.com/posit-dev/py-shiny/pull/1782/commits/d091ebdedb97b6f222f8284c5ac05695d1942b42)
cpsievert created a review comment on a pull request on posit-dev/py-shiny
Addressed as a note in [d091ebd](https://github.com/posit-dev/py-shiny/pull/1782/commits/d091ebdedb97b6f222f8284c5ac05695d1942b42) If you feel strongly about `.append()`, would you mind filing a...
cpsievert created a review comment on a pull request on posit-dev/py-shiny
Done in [add7b2f](https://github.com/posit-dev/py-shiny/pull/1782/commits/add7b2f48526adc67b8340ef77c2e76e8d4ac825)
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
Sorry, I found https://github.com/posit-dev/py-shiny/pull/1782#discussion_r1936243033 after writing this. But no, from a user perspective I don't think I'd find it weird. For me, the defining fe...
cpsievert created a review comment on a pull request on posit-dev/py-shiny
Done in [add7b2f](https://github.com/posit-dev/py-shiny/pull/1782/commits/add7b2f48526adc67b8340ef77c2e76e8d4ac825)
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
If we use `md.ui()`, we wouldn't have the "is it an output or not?" problem.
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
Could we make it work? If not, I think the documentation needs to be a bit stronger: like _don't use this in Core!_ But I'd rather not solve this with documentation; if we can save people from ...
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
lol I called this out in comments, I think the paired `@render...` function detail is probably not how most users will think of what's an output vs what's an input. I think that most people will se...
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
Might as well throw since it's in a message handler and won't bring down the app. That would just increase visibility (in dev mode we'd see the error in the client console).
cpsievert created a review comment on a pull request on posit-dev/py-shiny
If we call it `output_markdown_stream()`, would you expect there to be a `@render.markdown_stream`?