Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
karangattu created a review comment on a pull request on posit-dev/py-shiny
Sure, made the change it the latest commit.
karangattu created a review comment on a pull request on posit-dev/py-shiny
You are right. removed it in the commit
gadenbuie created a review on a pull request on posit-dev/py-shiny
Just two small comments, otherwise this looks good to me! Thanks @karangattu
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
Do we still need this? ```suggestion ```
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
This is very much a minor nit, but would you mind if we used IDs like `btn_*`, `value_box_*`, etc? E.g. `btn_default`, `btn_primary`, `value_box_primary`, etc.
karangattu created a comment on an issue on posit-dev/py-shiny
@MarcoGorelli Please update the `shiny` package to `1.2.1` by running ```sh pip install --upgrade shiny ``` to fix this issue.
karangattu closed an issue on posit-dev/py-shiny
Incompatibility with websockets 14
Hey - we're temporarily pinning websockets in the Narwhals CI downstream shiny job, as the new websockets release (which came out today) seems to be causing some pyright failures https://github.com...
karangattu created a review comment on a pull request on posit-dev/py-shiny
I have addressed it. check it now
wch created a comment on an issue on posit-dev/py-shiny
Looking back at the code for `RecallContextManager`, I believe this is this the reason why we made things the way they are currently. Each time there's a `with shiny.express.ui.div()` or `with shi...
gadenbuie published a release on posit-dev/py-shiny
shiny 1.2.1
### Bug fixes * Branded theming via `ui.Theme.from_brand()` now correctly applies monospace inline and block font family choices. (#1762) * Compatibility with `websockets>=14.0`, which has change...
thohan88 created a comment on an issue on posit-dev/py-shiny
After looking further into this, I realize this may be the intended behavior: https://github.com/rstudio/shiny/blob/501b012b2b82c0c468dc921ff0a3d9a682c20623/srcts/src/shiny/index.ts#L179-L192 For...
gadenbuie created a comment on an issue on posit-dev/py-shiny
I have a feeling that we could go all the way to the other side of the spectrum from where we are currently and only include things in the UI that are tagifiable or literal strings. Are there any o...
wch opened an issue on posit-dev/py-shiny
Shiny Express errors when trying to render `DuckDBPyConnection` object
The following app crashes on start because of the `con.register()` at the top level. [Live app](https://shinylive.io/py/editor/#code=NobwRAdghgtgpmAXGKAHVA6VBPMAaMAYwHsIAXOcpMAMwCdiYACAZwAsBLCbDOAD...
gadenbuie created a comment on a pull request on posit-dev/py-shiny
> Wonder if websockets would be open to a PR that silences this particular case... They might be open to it. It's very similar to another case where this kind of error appears that was fixed in ...
jcheng5 created a comment on a pull request on posit-dev/py-shiny
@gadenbuie Yeah, I ended up setting the environment variable in my `~/.zshrc`. I was thinking about just leaving it on but it really is so distracting to have two stack traces appear every time you...
gadenbuie pushed 1 commit to main posit-dev/py-shiny
- websockets 14.0 support (#1769) Co-authored-by: Garrick Aden-Buie <[email protected]> b3725f7
gadenbuie closed a pull request on posit-dev/py-shiny
websockets 14.0 support
See #1766 The websockets package released 14.0 which breaks us when using `shiny run --reload`. * As @gadenbuie noticed, the [`process_requests` callback has changed](https://websockets.readt...
karangattu created a comment on a pull request on posit-dev/py-shiny
> LGTM, thank you! > > @karangattu A note for QA: we should do some quick smoke tests in GitHub Codespaces, Posit Workbench, etc. before release just to be sure. Yes, I can test it as soon as...
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
```suggestion * Compatibility with `websockets>=14.0`, which has changed its public APIs. Shiny now requires websockets 13 or later (#1769). ```
gadenbuie created a review on a pull request on posit-dev/py-shiny
LGTM, thank you! @karangattu A note for QA: we should do some quick smoke tests in GitHub Codespaces, Posit Workbench, etc. before release just to be sure.