Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
cpsievert created a review comment on a pull request on posit-dev/py-shiny
Oh, I hadn't realized that `pip install brand_yml` actually works -- I thought it had to be `pip install brand-yml`
cpsievert created a comment on an issue on posit-dev/py-shiny
Glad you got vegafusion working! And, yes, change: ``` alt.data_transformers.enable("vegafusion") ``` to ``` _ = alt.data_transformers.enable("vegafusion") ``` and that error/message will go away
gadenbuie pushed 3 commits to feat/brand-yml posit-dev/py-shiny
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
It might be missing something but that's the intention, yeah. Since the theming packages are soft dependencies we need to prompt users to install `brand_yml` or `libsass` if not included (and one o...
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
Okay, this now happens in `brand_yml` via Pydantic's [serialization context](https://docs.pydantic.dev/2.9/concepts/serialization/#serialization-context). The feature is documented in brand_yml's [...
gadenbuie pushed 3 commits to feat/brand-yml posit-dev/py-shiny
cddesja-fda created a comment on an issue on posit-dev/py-shiny
It looks like literally doing what the message says works. That is changing the following line from ```python alt.data_transformers.enable("vegafusion") ``` to ```python str(alt.data_transformers.e...
cddesja-fda opened an issue on posit-dev/py-shiny
Using altair with a large dataset
In order to use altair for a dataset where the number of rows exceeds 5000, one needs to enable the VegaFusion data transformer. For example, creating the following simple Shiny app: ```python imp...
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
We talked through this in person and refactored again together.
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
Thanks, I tried both suggestions. You're right that these methods could take `brand.defaults` and the logic could be inlined. But I don't think it's cleaner when they're separated and I think `bran...
GiorgioMiglia created a comment on an issue on posit-dev/py-shiny
I ran your code in a devcontainer with Python 3.12.4 and Shiny, and it worked without any issues. This suggests the problem might not be with this snippet specifically, but rather with the overall ...
gadenbuie pushed 4 commits to feat/brand-yml posit-dev/py-shiny
cpsievert created a review comment on a pull request on posit-dev/py-shiny
Could reuse `_add_defaults_hdr()` here
cpsievert created a review comment on a pull request on posit-dev/py-shiny
Both of these methods could be passed just `brand.defaults`. I also feel like in this case, it's a bit cleaner to drop the `@staticmethod`s and just insert the relevant logic here.
gadenbuie pushed 1 commit to feat/brand-yml posit-dev/py-shiny
- chore: update type hint Co-authored-by: Carson Sievert <[email protected]> 0d72daa
cpsievert created a review comment on a pull request on posit-dev/py-shiny
This is gonna suggest `pip install brand_yml` if not installed already