Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ademidoff created a review comment on a pull request on percona/pmm
One more reason to do it - we lost the ability to use the native functionality that AWS CLI provides to pass ssh public keys to EC2 instances when we migrated from Amazon Linux 2 to an Oracle 9 bas...
ademidoff pushed 2 commits to PMM-12641-optimize-pmm-build-scripts percona/pmm
ademidoff created a review comment on a pull request on percona/pmm
I don't think your argument is valid about the security team - they don't monitor the pipelines. But OK, it's not a big deal - I'll remove it.
BupycHuk created a review comment on a pull request on percona/pmm
it copies into /srv directory which we delete anyway on post-build-actions and can be done on user side.
BupycHuk created a review comment on a pull request on percona/pmm
One more call to github isn't that critical for efficiency. it's not a common case to add ssh key to base image. There we can clearly see in logs that these keys were added and we can control o...
ademidoff created a review comment on a pull request on percona/pmm
It's about efficiency, transparency is the same, I believe - both are public repos.
BupycHuk created a review comment on a pull request on percona/pmm
Do we really need to start supervisor and initialization playbook?
BupycHuk created a review comment on a pull request on percona/pmm
I believe it should stay in jenkins pipelines for better transparency.
ademidoff created a review comment on a pull request on percona/pmm
Sorry, I'm not sure I understand the question.
ademidoff created a review comment on a pull request on percona/pmm
Why? It's analogous (or even a potential replacement of) to [this](https://github.com/Percona-Lab/jenkins-pipelines/blob/master/vars/getSHHKeysPMM.groovy#L5-L9), except that in this case we don't b...
ademidoff created a review comment on a pull request on percona/pmm
Good catch 👍 I have not tested, but maybe we don't need it.
BupycHuk created a review comment on a pull request on percona/pmm
if we don't autostart it, do we really need this file?
ademidoff pushed 2 commits to PMM-12641-optimize-pmm-build-scripts percona/pmm