Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
sschuberth pushed 2 commits to fix-id-to-purl-conversion oss-review-toolkit/ort
codecov[bot] created a comment on a pull request on oss-review-toolkit/ort
## [Codecov](https://app.codecov.io/gh/oss-review-toolkit/ort/pull/9331?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=os...
renovate[bot] opened a pull request on oss-review-toolkit/ort
deps: update jetbrains/qodana-action action to v2024.2.5
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [JetBrains/qodana-action](https://redirect.github.com/JetBrains/qodana-action) | action | patch | `...
renovate[bot] created a branch on oss-review-toolkit/ort
renovate/jetbrains-qodana-action-2024.x - A suite of tools to automate software compliance checks.
fviernau pushed 6 commits to main oss-review-toolkit/ort
- docs(yarn): Re-align the docs with the function This is a fix-up for ad9a363. Signed-off-by: Frank Viernau <frank_v... 02192a3
- docs(yarn): Add information about the mentioned network issue Signed-off-by: Frank Viernau <[email protected]> 0460948
- refactor(npm): Allow `getRemotePackageDetails()` to return `null` Prepare for an upcoming change that signals that p... 771a6a5
- refactor(yarn): Use a more speaking name for `output` This function is not suitable for parsing the JSON objects on ... 8e90a79
- refactor(yarn): Extract `extractDataNodes()` Avoid code duplication in an upcoming change. Signed-off-by: Frank Vie... 26703f9
- fix(yarn): Fix up the error handling in `getRemotePackageDetails()` Previously, calling `parseYarnInfo(process.stder... 41d1c6f
fviernau closed a pull request on oss-review-toolkit/ort
Yarn info parsing fixes
See individual commits. Part of https://github.com/oss-review-toolkit/ort/issues/9261.
fviernau pushed 24 commits to yarn-simplifcations oss-review-toolkit/ort
- refactor(model): Move `RootLicenseMatcherTest` to the correct package Signed-off-by: Sebastian Schuberth <sebastian@... 1151e95
- refactor(model)!: Rename a class to `PathLicenseMatcher` The name `RootLicenseMatcher` was confusing as not necessar... 131c130
- docs(model): Improve `LicenseFilePatterns` docs Add class docs and slightly reword property docs, also reducing sent... 786aba4
- refactor(model): Make `LicenseFilePatterns` properties sets This better reflects that duplicates make no sense. Sig... 6c7a4b1
- refactor(model)!: Rename a `LicenseFilePatterns` property `rootLicenseFilenames` sounded too much as if it would tak... d1fa585
- chore(model)!: Remove old plugin config aliases The old names were deprecated more than a year ago, so it should be ... e4e8396
- deps: update ksp to v2.0.21-1.0.26 d169fae
- feat(spdx): Deal with cycles in dependency relations Circular dependency relations caused the SPDX package manager t... c9d2a49
- docs(model): Clarify in a test what a "clean" purl is supposed to be Signed-off-by: Sebastian Schuberth <sebastian@d... 1219605
- chore(model): Nest purl tests in preparation for adding more tests Signed-off-by: Sebastian Schuberth <sebastian@dou... d2dd061
- chore: Align on "purl" spelling for Package URLs That seems to be the official spelling, see [1]. [1]: https://gith... 4814301
- refactor(model): Move purl-related tests to `PurlExtensionsTest` Signed-off-by: Sebastian Schuberth <sebastian@doubl... 7f07648
- chore(model): Remove a few redundant purl tests Qualifiers are already tested as part of provenance conversion. Sig... 2c79d17
- fix(model): Rework purl conversion according to the specs Implement the pseudo-algorithm described at [1]. Most impo... b1740ef
- test(model): Test against the official purl test suite data The data has been copied from [1]. [1]: https://github.... 419b42b
- docs(yarn): Re-align the docs with the function This is a fix-up for ad9a363. Signed-off-by: Frank Viernau <frank_v... 24ffaee
- docs(yarn): Add information about the mentioned network issue Signed-off-by: Frank Viernau <[email protected]> 65ad36f
- refactor(npm): Allow `getRemotePackageDetails()` to return `null` Prepare for an upcoming change that signals that p... 299a471
- refactor(yarn): Use a more speaking name for `output` This function is not suitable for parsing the JSON objects on ... 77602a2
- refactor(yarn): Extract `extractDataNodes()` Avoid code duplication in an upcoming change. Signed-off-by: Frank Vie... 9d5c10b
- and 4 more ...
fviernau pushed 6 commits to yarn-info-parsing-fixes oss-review-toolkit/ort
- docs(yarn): Re-align the docs with the function This is a fix-up for ad9a363. Signed-off-by: Frank Viernau <frank_v... 24ffaee
- docs(yarn): Add information about the mentioned network issue Signed-off-by: Frank Viernau <[email protected]> 65ad36f
- refactor(npm): Allow `getRemotePackageDetails()` to return `null` Prepare for an upcoming change that signals that p... 299a471
- refactor(yarn): Use a more speaking name for `output` This function is not suitable for parsing the JSON objects on ... 77602a2
- refactor(yarn): Extract `extractDataNodes()` Avoid code duplication in an upcoming change. Signed-off-by: Frank Vie... 9d5c10b
- fix(yarn): Fix up the error handling in `getRemotePackageDetails()` Previously, calling `parseYarnInfo(process.stder... f6f9054
codecov[bot] created a comment on a pull request on oss-review-toolkit/ort
## [Codecov](https://app.codecov.io/gh/oss-review-toolkit/ort/pull/9330?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=os...
sschuberth opened a draft pull request on oss-review-toolkit/ort
Fix `Identifier` to purl conversion
Please have a look at the individual commit messages for the details.
sschuberth created a branch on oss-review-toolkit/ort
fix-id-to-purl-conversion - A suite of tools to automate software compliance checks.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Yes, makes sense to me.
fviernau pushed 1 commit to yarn-info-parsing-fixes oss-review-toolkit/ort
- fix(yarn): Fix up the error handling in `getRemotePackageDetails()` Previously, calling `parseYarnInfo(process.stder... 5f0b70d
fviernau pushed 5 commits to yarn-info-parsing-fixes oss-review-toolkit/ort
- docs(yarn): Add information about the mentioned network issue Signed-off-by: Frank Viernau <[email protected]> a8690fe
- refactor(npm): Allow `getRemotePackageDetails()` to return `null` Prepare for an upcoming change that signals that p... 35d4f3b
- refactor(yarn): Use a more speaking name for `output` This function is not suitable for parsing the JSON objects on ... bf58896
- refactor(yarn): Extract `extractDataNodes()` Avoid code duplication in an upcoming change. Signed-off-by: Frank Vie... f3889be
- fix(yarn): Fix up the error handling in `getRemotePackageDetails()` Previously, calling `parseYarnInfo(process.stder... 58af405
fviernau created a review comment on a pull request on oss-review-toolkit/ort
As ORT's execution still is "successful" (you can rely on the result), I would propose to log the errors as "warnings". (And then in a following change log warnings either as info or debug). Wou...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Also, as these are errors on the Yarn side, should be log to error level, too? This would even make more sense when also parsing for warnings explicitly in a follow-up commit, as these would then b...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Nits: - "yarn" -> "Yarn" - Probably drop the trailing "." as `content` could already contain it.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Commit message: - "because `npm`" -> "because Yarn" - "[1] https://github.com/oss-review-toolkit/ort/commit/ad9a3639604aacfa6aa3fd831593201f42e78483" -> "[1]: https://github.com/oss-review-toolki...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Probably better use `.getOrDefault(emptySet())`.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Maybe say explicitly in the commit message "This function is not suitable for parsing the JSON objects on `stderr` as-is.".
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
This change should go to the previous commit.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Maybe extend the commit message a bit by saying: "Prepare for an upcoming change that signals that parsing of `PackageJson` data was unsuccessful."
fviernau pushed 1 commit to yarn-info-parsing-fixes oss-review-toolkit/ort
- fix(yarn): Fix up the error handling in `getRemotePackageDetails()` Previously, calling `parseYarnInfo(process.stder... e297b5a
fviernau pushed 1 commit to yarn-info-parsing-fixes oss-review-toolkit/ort
- fix(yarn): Fix up the error handling in `getRemotePackageDetails()` Previously, calling `parseYarnInfo(process.stder... a12ad89