Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Discarding an intermediate ".." indeed does not make any sense, so I went for normalizing as it at least doe snot break the test suite.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Let's keep it now that I've changed it.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
I'd prefer to stick to `KNOWN_QUALIFIER_KEYS`. It's shorter and does not hard-code any implications into its name.
fviernau created a review comment on a pull request on oss-review-toolkit/ort
Sorry for the typo in `KNOW_QUALIFIER_KEYS`, it made it into the diff.
fviernau created a comment on a pull request on oss-review-toolkit/ort
> Wouldn't we get test failures then? In expected output like files yet, in file which are used only as input probably no.
fviernau created a review comment on a pull request on oss-review-toolkit/ort
> Well, the algorithm description says to "Discard empty, '.' and '..' segments", not to normalize paths. My bad, I've written this after reading the `purl parsing algo` by accident instead of ...
fviernau created a review comment on a pull request on oss-review-toolkit/ort
oh, it's to be more close to the algo description. Then just ignore my comment.
fviernau created a review comment on a pull request on oss-review-toolkit/ort
Does the de-serialization of the config fail in case the alias is omit? If yes (it does not go unnoticed), shall we just make this a breaking change to avoid having this historical thing in the code?
fviernau created a review comment on a pull request on oss-review-toolkit/ort
Should the reference config be updated as well?
fviernau created a review comment on a pull request on oss-review-toolkit/ort
commit-msg: typo in `patters`
fviernau created a comment on a pull request on oss-review-toolkit/ort
> Note that I stopped reviewing at the second commit as I believe it needs to be reworked, and all further changes build upon it. I've commented on your comments. It'd be great to get some more ...
fviernau created a review comment on a pull request on oss-review-toolkit/ort
> > While at it, stop to attempt parsing `stderr` to a `PackageJson` instance, because `stderr` won't contain that. > > I don't think that's correct. For example `yarn info --json foo.txt > /dev...
fviernau created a review comment on a pull request on oss-review-toolkit/ort
> That's not correct. `run()` just returns a `ProcessCapture` instance and does not throw on a non-zero exit code unless also `requireSuccess()` is called. This is what I've been assuming as wel...
sschuberth pushed 1 commit to lfp-imps oss-review-toolkit/ort
- refactor(model): Rename a `LicenseFilePatterns` property `rootLicenseFilenames` sounded too much as if it would take... e127953
codecov[bot] created a comment on a pull request on oss-review-toolkit/ort
## [Codecov](https://app.codecov.io/gh/oss-review-toolkit/ort/pull/9325?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=os...
sschuberth pushed 1 commit to lfp-imps oss-review-toolkit/ort
- refactor(model): Rename a `LicenseFilePatterns` property `rootLicenseFilenames` sounded too much as if it would take... 2fc2f9c
sschuberth created a branch on oss-review-toolkit/ort
lfp-imps - A suite of tools to automate software compliance checks.
sschuberth created a comment on a pull request on oss-review-toolkit/ort
> I added a test cases, hoping that this is what you had in mind. Hmm, not really. I was hoping for a funTest that queries VC for a Go package which is known to have vulnerabilities. When run ag...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
> While at it, stop to attempt parsing `stderr` to a `PackageJson` instance, because `stderr` won't contain that. I don't think that's correct. For example `yarn info --json foo.txt > /dev/null`...
sschuberth created a review on a pull request on oss-review-toolkit/ort
Note that I stopped reviewing at the second commit as I believe it needs to be reworked, and all further changes build upon it.