Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
fviernau created a review comment on a pull request on oss-review-toolkit/ort
> Well, the algorithm description says to "Discard empty, '.' and '..' segments", not to normalize paths. My bad, I've written this after reading the `purl parsing algo` by accident instead of ...
fviernau created a review comment on a pull request on oss-review-toolkit/ort
oh, it's to be more close to the algo description. Then just ignore my comment.
fviernau created a review comment on a pull request on oss-review-toolkit/ort
Does the de-serialization of the config fail in case the alias is omit? If yes (it does not go unnoticed), shall we just make this a breaking change to avoid having this historical thing in the code?
fviernau created a review comment on a pull request on oss-review-toolkit/ort
Should the reference config be updated as well?
fviernau created a review comment on a pull request on oss-review-toolkit/ort
commit-msg: typo in `patters`
fviernau created a comment on a pull request on oss-review-toolkit/ort
> Note that I stopped reviewing at the second commit as I believe it needs to be reworked, and all further changes build upon it. I've commented on your comments. It'd be great to get some more ...
fviernau created a review comment on a pull request on oss-review-toolkit/ort
> > While at it, stop to attempt parsing `stderr` to a `PackageJson` instance, because `stderr` won't contain that. > > I don't think that's correct. For example `yarn info --json foo.txt > /dev...
fviernau created a review comment on a pull request on oss-review-toolkit/ort
> That's not correct. `run()` just returns a `ProcessCapture` instance and does not throw on a non-zero exit code unless also `requireSuccess()` is called. This is what I've been assuming as wel...
sschuberth pushed 1 commit to lfp-imps oss-review-toolkit/ort
- refactor(model): Rename a `LicenseFilePatterns` property `rootLicenseFilenames` sounded too much as if it would take... e127953
codecov[bot] created a comment on a pull request on oss-review-toolkit/ort
## [Codecov](https://app.codecov.io/gh/oss-review-toolkit/ort/pull/9325?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=os...
sschuberth pushed 1 commit to lfp-imps oss-review-toolkit/ort
- refactor(model): Rename a `LicenseFilePatterns` property `rootLicenseFilenames` sounded too much as if it would take... 2fc2f9c
sschuberth created a branch on oss-review-toolkit/ort
lfp-imps - A suite of tools to automate software compliance checks.
sschuberth created a comment on a pull request on oss-review-toolkit/ort
> I added a test cases, hoping that this is what you had in mind. Hmm, not really. I was hoping for a funTest that queries VC for a Go package which is known to have vulnerabilities. When run ag...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
> While at it, stop to attempt parsing `stderr` to a `PackageJson` instance, because `stderr` won't contain that. I don't think that's correct. For example `yarn info --json foo.txt > /dev/null`...
sschuberth created a review on a pull request on oss-review-toolkit/ort
Note that I stopped reviewing at the second commit as I believe it needs to be reworked, and all further changes build upon it.
sschuberth created a review on a pull request on oss-review-toolkit/ort
Note that I stopped reviewing at the second commit as I believe it needs to be reworked, and all further changes build upon it.
sschuberth pushed 2 commits to main oss-review-toolkit/ort
sschuberth closed a pull request on oss-review-toolkit/ort
Rename `RootLicenseMatcher` to `PathLicenseMatcher`
Please have a look at the individual commit messages for the details.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
> to capture that the license is somewhat originating from special files I believe that "License" in "PathLicenseMatcher" already makes clear enough that only special files, namely *license* fi...
sschuberth created a comment on an issue on oss-review-toolkit/ort
While I can't reproduce this locally, I can when using the Docker image. Anyway, I guess it's not `python-inspector` itself than cannot be found, but some dependency of it. I currently don't have t...
sschuberth pushed 2 commits to purl-imps oss-review-toolkit/ort