Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
sschuberth created a review on a pull request on oss-review-toolkit/ort
Note that I stopped reviewing at the second commit as I believe it needs to be reworked, and all further changes build upon it.
sschuberth pushed 2 commits to main oss-review-toolkit/ort
sschuberth closed a pull request on oss-review-toolkit/ort
Rename `RootLicenseMatcher` to `PathLicenseMatcher`
Please have a look at the individual commit messages for the details.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
> to capture that the license is somewhat originating from special files I believe that "License" in "PathLicenseMatcher" already makes clear enough that only special files, namely *license* fi...
sschuberth created a comment on an issue on oss-review-toolkit/ort
While I can't reproduce this locally, I can when using the Docker image. Anyway, I guess it's not `python-inspector` itself than cannot be found, but some dependency of it. I currently don't have t...
sschuberth pushed 2 commits to purl-imps oss-review-toolkit/ort
sschuberth created a comment on a pull request on oss-review-toolkit/ort
> Have you checked whether any test assets using urls e.g. `OrtResult`, need to be re-aligned with these changes? Wouldn't we get test failures then? But actually I'm wasn't expecting *this* PR ...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
I've introduced the `testCase(s)` variables, but kept `testData(File)`.
codecov[bot] created a comment on a pull request on oss-review-toolkit/ort
## [Codecov](https://app.codecov.io/gh/oss-review-toolkit/ort/pull/9324?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=os...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
I did use `forAll` at first, but it provides less readable output for multiple failing assertions.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
> This filtering does not work for paths like#. `a/b/c/../d`. Well, the algorithm description says to "Discard empty, '.' and '..' segments", not to normalize paths. Do you think we should still...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
I also struggled to find explicit docs about this, but without it the test suite fails.
renovate[bot] created a branch on oss-review-toolkit/ort
renovate/actions-checkout-digest - A suite of tools to automate software compliance checks.
sschuberth pushed 14 commits to purl-imps oss-review-toolkit/ort
- deps: update dependency org.wiremock:wiremock to v3.9.2 606c475
- test(pub): Update expected results Signed-off-by: Sebastian Schuberth <[email protected]> c1c7907
- deps(docker): Upgrade Askalono to version 0.5.0 See [1]. [1]: https://github.com/jpeddicord/askalono/releases/tag/0... e65ff6b
- fix(jenkins): Allow to select DOS as a project and package scanner This is a fixup for ae0ca85. Signed-off-by: Seba... 1b83831
- deps: update dependency com.squareup:kotlinpoet to v2 8885a75
- refactor(npm): Remove unused parallelization constructs The code looks like it would run things in parallel, but it ... cbdb228
- refactor(npm): Drop a slightly misleading log output The log message sounds as if the function would have searched t... 7143c32
- docs(model): Clarify in a test what a "clean" purl is supposed to be Signed-off-by: Sebastian Schuberth <sebastian@d... 08c32d2
- chore(model): Nest purl tests in preparation for adding more tests Signed-off-by: Sebastian Schuberth <sebastian@dou... 145046b
- chore: Align on "purl" spelling for Package URLs That seems to be the official spelling, see [1]. [1]: https://gith... 0475061
- refactor(model): Move purl-related tests to `PurlExtensionsTest` Signed-off-by: Sebastian Schuberth <sebastian@doubl... 3495373
- chore(model): Remove a few redundant purl tests Qualifiers are already tested as part of provenance conversion. Sig... 036bcb4
- fix(model): Rework purl conversion according to the specs Implement the pseudo-algorithm described at [1]. Most impo... 6978919
- test(model): Test against the official purl test suite data The data has been copied from [1]. [1]: https://github.... 1a7f223
fviernau created a comment on a pull request on oss-review-toolkit/ort
> @fviernau I think I understand your concerns. However, my key issue is that there are very large repositories that act as kind of umbrella around other repositories, having already **more than 50...
wkl3nk created a comment on a pull request on oss-review-toolkit/ort
@sschuberth I added a test cases, hoping that this is what you had in mind. It will start to fail once the slashes in the purl name section are no longer percent-encoded. Once this test fails, this...
wkl3nk created a comment on a pull request on oss-review-toolkit/ort
@fviernau I think I understand your concerns. However, my key issue is that there are very large repositories that act as kind of umbrella around other repositories, having already **more than 50 g...
fviernau pushed 1 commit to yarn-simplifcations oss-review-toolkit/ort
- refactor(npm): Move `parsePackage()` outside of the `Npm` class Prepare for re-using this function from other child ... e2ace56
fviernau pushed 3 commits to yarn-simplifcations oss-review-toolkit/ort
- refactor(yarn): Improve `getRemotePackageDetails()` The `run()` function throws in case the commands' exit code was ... 3577b22
- refactor(npm): Make `getRemotePackageDetails()` handle unsucessful runs This way `getRemotePackageDetails()` shouldn... ff5e498
- refactor(npm): Remove a now unnecessary `runCatching()` All implementations of `getRemotePackageDetails()` by now gr... b8b7c75
fviernau created a comment on a pull request on oss-review-toolkit/ort
> I believe it makes sense to have the ability to configure this separate per dependency. I expect the following trade-off / approach to be reasonable for some users: > > 1. Enable submodule...
wkl3nk created a review comment on a pull request on oss-review-toolkit/ort
Now the VCS-specific configuration can also be modified via `config.yml`, I added an example in `reference.yml` (see [here](https://github.com/boschglobal/oss-review-toolkit/blob/a7c9533513dc8ea798...