Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
github-advanced-security[bot] created a review comment on a pull request on oss-review-toolkit/ort
## Unnecessary safe call operator detected. config?.getVersionControlSystemConfiguration(applicableVcs.type) contains an unnecessary safe call operator [Show more details](https://github.com/oss-...
github-advanced-security[bot] created a review comment on a pull request on oss-review-toolkit/ort
## Format signature to be single when possible, multiple lines otherwise. First line of body expression fits on same line as function signature [Show more details](https://github.com/oss-review-t...
fviernau pushed 6 commits to yarn-simplifcations oss-review-toolkit/ort
- refactor(npm): Remove unused parallelization constructs The code looks like it would run things in parallel, but it ... cbdb228
- refactor(npm): Drop a slightly misleading log output The log message sounds as if the function would have searched t... 7143c32
- refactor(npm): Allow `getRemotePackageDetails()` to return `null` Prepare for an upcoming change. Signed-off-by: Fr... d1db99c
- refactor(yarn): Improve `getRemotePackageDetails()` In case the process was successful, do no log `process.stderr` a... b2ef1bb
- refactor(npm): Make `getRemotePackageDetails()` handle the exit code This way `parsePackageJson()` shouldn't throw a... 0fd73c8
- refactor(npm): Remove a now unnecessary `runCatching()` All implementations of `getRemotePackageDetails()` by now gr... 8409ba2
sschuberth pushed 2 commits to main oss-review-toolkit/ort
sschuberth closed a pull request on oss-review-toolkit/ort
refactor(npm): Remove unused parallelization constructs
The code looks like it would run things in parallel, but it executes `getRemotePackageDetails()` strictly sequentially. The pull request which had introduced these constructs [1] also introduced th...
codecov[bot] created a comment on a pull request on oss-review-toolkit/ort
## [Codecov](https://app.codecov.io/gh/oss-review-toolkit/ort/pull/9323?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=os...
fviernau pushed 3 commits to yarn-simplifcations oss-review-toolkit/ort
- refactor(yarn): Improve `getRemotePackageDetails()` In case the process was successful, do no log `process.stderr` a... bbb02af
- refactor(npm): Make `getRemotePackageDetails()` handle the exit code This way `parsePackageJson()` shouldn't throw a... ec60b74
- refactor(npm): Remove a now unnecessary `runCatching()` All implementations of `getRemotePackageDetails()` by now gr... fb55fa1
fviernau pushed 4 commits to yarn-simplifcations oss-review-toolkit/ort
- refactor(npm): Allow `getRemotePackageDetails()` to return `null` Prepare for an upcoming change. Signed-off-by: Fr... 611a8f7
- refactor(yarn): Simplify `getRemotePackageDetails()` In case the process was successful, do no log `process.stderr` ... 89c9e17
- refactor(npm): Make `getRemotePackageDetails()` handle the exit code This way `parsePackageJson()` shouldn't throw a... aa1d06b
- refactor(npm): Remove a now unnecessary `runCatching()` All implementations of `getRemotePackageDetails()` by now gr... 191e933
fviernau opened a pull request on oss-review-toolkit/ort
node: Some simplifications and improvements
Simplify the code around `parsePackage()` and `getRemotePackageDetails()`, to prepare for an upcoming refactoring. Part of #9261.
fviernau created a branch on oss-review-toolkit/ort
yarn-simplifcations - A suite of tools to automate software compliance checks.
bennati created a comment on an issue on oss-review-toolkit/ort
I tested with version [6bb98df](https://github.com/oss-review-toolkit/ort/commit/6bb98df) and the error is still there
fviernau created a review comment on a pull request on oss-review-toolkit/ort
Just one more idea: How about combining `Path` with `Main` to capture that the license is somewhat originating from special files, not any location? `PathMainLicenseMatcher` ?
sschuberth pushed 1 commit to main oss-review-toolkit/ort
- deps: update dependency com.squareup:kotlinpoet to v2 8885a75
fviernau created a comment on a pull request on oss-review-toolkit/ort
I haven't done the grepping myself: Have you checked whether any test assets using urls e.g. `OrtResult`, need to be re-aligned with these changes?
fviernau created a review comment on a pull request on oss-review-toolkit/ort
I've been trying to find the info in above linked docs without success. Can you give a hint how you arrived at KNOWN_KEYS being the set of qualifiers which need no encoding?
fviernau created a review comment on a pull request on oss-review-toolkit/ort
This filtering does not work for paths like#. `a/b/c/../d`. Can it actually happen at all that we get any `.` or `..` inside the input?
fviernau created a review comment on a pull request on oss-review-toolkit/ort
Could the `else` be dropped and line 102 be executed in any case (outside the `if`) ?
fviernau created a review comment on a pull request on oss-review-toolkit/ort
consider extracting a `val purl`
fviernau created a review comment on a pull request on oss-review-toolkit/ort
Should this link go to the `KNOWN_KEYS` docs?
fviernau created a review comment on a pull request on oss-review-toolkit/ort
I believe it would be valuable to rename to `TestCase` and move the filtering up, as follows: ``` val testCases = File("test-suite-data.json").readValue<List<TestCase>>().filterNot { it.isInvalid...
fviernau created a review comment on a pull request on oss-review-toolkit/ort
Probably should use `forAll` insead of `assertSoftly` and `forEach`.
fviernau created a review comment on a pull request on oss-review-toolkit/ort
Propose to rename this to `KNOW_QUALIFIER_KEYS` or `KNOWN_QUALIFIERS`.
codecov[bot] created a comment on a pull request on oss-review-toolkit/ort
## [Codecov](https://app.codecov.io/gh/oss-review-toolkit/ort/pull/9322?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=os...