Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
sschuberth pushed 2 commits to main oss-review-toolkit/ort
- test(pub): Update expected results Signed-off-by: Sebastian Schuberth <[email protected]> 8808d0c
- test(osv): Update expected results Signed-off-by: Sebastian Schuberth <[email protected]> 6bb98df
sschuberth pushed 1 commit to pub-funtest-update oss-review-toolkit/ort
- test(osv): Update expected results Signed-off-by: Sebastian Schuberth <[email protected]> bb4dd7b
sschuberth created a branch on oss-review-toolkit/ort
pub-funtest-update - A suite of tools to automate software compliance checks.
sschuberth pushed 2 commits to purl-imps oss-review-toolkit/ort
sschuberth created a comment on a pull request on oss-review-toolkit/ort
In any case, @wkl3nk as mentioned [here](https://github.com/oss-review-toolkit/ort/issues/9298#issuecomment-2419213085) please add a test for this (in a new commit that could easily be cherry-picke...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
It does not make sense to log these as both warnings and errors.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
We should not keep code like this.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
All other plugins that take options just use constants for key names, and I believe we should do the same here, for consistency and to reduce complexity. I guess this will get reworked anyway once ...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Just adding an unused option to the function signature does not fix anything, so you should not say so in the commit message. Most importantly, these options are not read from the configuration fil...
sschuberth created a comment on a pull request on oss-review-toolkit/ort
I still believe we should solve this differently, in a more generic way. While Go apparently does not have namespaces, the purl standard treats them as if Go had namespaces. I'm currently preparing...
fviernau created a comment on a pull request on oss-review-toolkit/ort
> @fviernau Hello, can you explain a little bit more please? I believe it makes sense to have the ability to configure this separate per dependency. I expect the following trade-off to be reaso...
wkl3nk created a comment on a pull request on oss-review-toolkit/ort
@fviernau Hello, can you explain a little bit more please?
fviernau created a comment on a pull request on oss-review-toolkit/ort
I believe the options for configuring submodule recursion could be injected via package curations. Have you considered this?
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
At least @mnonnenmacher is on vacation, and I'd like to proceed with this before he's back in two weeks.
fviernau created a review comment on a pull request on oss-review-toolkit/ort
Puh, I'm having a hard time deciding this (except that I would not use Applicable because also licenses in other files can be applicable). Let's maybe do a quick poll on the preferred terminology. ...
sschuberth pushed 1 commit to main oss-review-toolkit/ort
- chore(scanner): Give a variable in a test a better name Signed-off-by: Sebastian Schuberth <[email protected]> e612c50
sschuberth closed a pull request on oss-review-toolkit/ort
chore(scanner): Give a variable in a test a better name
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
I believe "Main" has the same notion as "Root" in that it can be interpreted to only mean the license in the top-level directory. More ideas: - AncestorLicenseMatcher - InheritedLicenseMatcher ...
fviernau created a comment on a pull request on oss-review-toolkit/ort
> @fviernau mind having a look as I have some follow-up changes? Sorry, missed that my comment was in "pending" state.
codecov[bot] created a comment on a pull request on oss-review-toolkit/ort
## [Codecov](https://app.codecov.io/gh/oss-review-toolkit/ort/pull/9314?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=os...
