Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
sschuberth pushed 5 commits to pub-imps oss-review-toolkit/ort
- refactor(pub): Reduce code by delegating to the default serializer Signed-off-by: Sebastian Schuberth <sebastian@dou... 8be16d9
- chore(pub): Simplify deserializing dependencies The dependencies node itself is never a scalar, so the code can be s... ae06cfc
- chore(pub): Handle dependency types in the same order as documented Signed-off-by: Sebastian Schuberth <sebastian@do... 4a3c230
- refactor(pub): Reorder classes into packages Remove the `utils` package and move its only class to the root. In exch... e045fbd
- refactor(pub): Only use a single shared YAML instance Signed-off-by: Sebastian Schuberth <[email protected]> c643da0
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Why would encapsulation even be required here? I mean, these two files *are* supposed to be deserialized in exactly the same way, so it makes sense and is correct to share the same `Yaml` instance,...
codecov[bot] created a comment on a pull request on oss-review-toolkit/ort
## [Codecov](https://app.codecov.io/gh/oss-review-toolkit/ort/pull/9304?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=os...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
I still don't believe it makes sense to stick with `url` in the longer term as it would break as soon as we'd be able to deserialize classes directly (see https://github.com/charleskorn/kaml/issues...
sschuberth pushed 11 commits to pub-imps oss-review-toolkit/ort
- fix(cli): Remove credentials from environment variables Do not expose any credentials, e.g. when included in proxy U... 03b4ed9
- deps: update dependency com.github.jmongard.git-semver-plugin to v0.12.11 ed4bccf
- chore: Align custom kotlinx-serializers to be objects, part 2 This is a follow-up to 9607cd0 for code that was merge... ff8bbc6
- docs(pub): Add links to dependency types Signed-off-by: Sebastian Schuberth <[email protected]> e59225e
- chore(pub): Order dependency classes as in the linked documentation Signed-off-by: Sebastian Schuberth <sebastian@do... 6e834c3
- fix(pub): Use the correct property name for own package repositories The property is called `hosted`, not `url`, see... 0672adb
- refactor(pub): Reduce code by delegating to the default serializer Signed-off-by: Sebastian Schuberth <sebastian@dou... aad9cd1
- chore(pub): Simplify deserializing dependencies The dependencies node itself is never a scalar, so the code can be s... beb0839
- chore(pub): Handle dependency types in the same order as documented Signed-off-by: Sebastian Schuberth <sebastian@do... 4bfdc1c
- refactor(pub): Reorder classes into packages Remove the `utils` package and move its only class to the root. In exch... aa01289
- refactor(pub): Only use a single shared YAML instance Signed-off-by: Sebastian Schuberth <[email protected]> 5710c21
sschuberth opened a draft pull request on oss-review-toolkit/ort
Purl-related improvements
Please have a look at the individual commit messages for the details.
sschuberth created a branch on oss-review-toolkit/ort
purl-imps - A suite of tools to automate software compliance checks.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Agreed, it seem odd that Copyrights are wrapped in `CDATA` if part of `<evidence>`, but not otherwise.
sschuberth created a comment on a pull request on oss-review-toolkit/ort
> @sschuberth Funnily enough, I found out you had an `escapeXML` function in the past: https://github.com/oss-review-toolkit/ort/pull/2820/files Yes, that's what I wrote over [here](https://gith...
nnobelis created a comment on a pull request on oss-review-toolkit/ort
Funnily enough, I found out you had an `escapeXML` function in the past: https://github.com/oss-review-toolkit/ort/pull/2820/files
nnobelis created a review comment on a pull request on oss-review-toolkit/ort
In the test you linked, the copyright is under an `evidence` element: ``` <component type="application"> <evidence> <copyright> ``` And `Component.evidence.copyr...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
> Also, I remember that somewhere we had a discussion about wrapping Copyright texts in `<![CDATA[...]]>`, but I currently cannot find it anymore. Would that also solve the issue? Assuming that ...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Somewhat related, though targeting the description: https://github.com/oss-review-toolkit/ort/issues/2814
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
Also, I remember that somewhere we had a discussion about wrapping Copyright texts in `CDATA`, but I currently cannot find it anymore. Would that also solve the issue?
nnobelis created a review comment on a pull request on oss-review-toolkit/ort
Fell free to suggest one! I didn't find anything by googling. The Cyclone DX lib delegates to Jackson for the XML generation that delegates to StAX, but I found nothing there too :disappointed:
codecov[bot] created a comment on a pull request on oss-review-toolkit/ort
## [Codecov](https://app.codecov.io/gh/oss-review-toolkit/ort/pull/9303?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=os...
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
I'm not super happy about introducing a dependency on `commons-text` just for escaping XML... can we find a more lightweight solution?
nnobelis opened a pull request on oss-review-toolkit/ort
fix(cyclonedx): Sanitize copyrights for the CycloneDX XML report
Some characters in copyrights cannot be outputted to XML. Therefore, sanitize the copyrights content for XML. This fixes the following exception: > org.cyclonedx.exception.GeneratorException:...
codecov[bot] created a comment on a pull request on oss-review-toolkit/ort
## [Codecov](https://app.codecov.io/gh/oss-review-toolkit/ort/pull/9302?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=os...
sschuberth opened a pull request on oss-review-toolkit/ort
Rename `RootLicenseMatcher` to `ParentLicenseMatcher`
Please have a look at the individual commit messages for the details.
sschuberth created a branch on oss-review-toolkit/ort
rlm-imps - A suite of tools to automate software compliance checks.
sschuberth created a review comment on a pull request on oss-review-toolkit/ort
> there is no more way back to the "mixed" ORT purl. Correct, but my point is that my implementation proposal should not require you to go back, as the VC-style-PURL is only used for the lookup ...