Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
sonarcloud[bot] created a comment on a pull request on oraichain/oraiswap-frontend
## [](https://sonarcloud.io/dashboard?id=...
vuonghuuhung pushed 5 commits to feat/new-v3 oraichain/oraiswap-frontend
- update code for fixing convert btc v2 7dfe197
- Merge pull request #999 from oraichain/hot_fix/fix_fetching_price_btc_on_converting_btc update code for fixing conve... 6719225
- fix inj tia follow new msg 7952954
- Merge pull request #1000 from oraichain/fix/inj-tia-new-msg fix inj tia follow new msg 64fd04f
- Merge branch 'main' into feat/new-v3 7df40f6
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Reassess the condition for executing 'changeRangeHandler'** The condition `if ((minTick !== 0 || maxTick !== 0) && pool && tokenX && tokenY)` will execute `changeRan...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Ensure proper validation of 'minTick' and 'maxTick' when they can be zero** The condition `if (!(pool && minTick && maxTick)) return;` can incorrectly prevent execut...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Specify a more precise type for 'scale' instead of 'any'** To enhance type safety and code clarity, consider specifying a more precise type for the `sc...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **'zero' is not a valid property for scale configurations** The `zero` property in the scale configuration is not recognized by `@visx/xychart` scales and may not have...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Fix the condition in `getCorrespondingTickRange` function** The condition `if (minPrice === 0 || maxPrice === 0)` is using local variables `minPrice` and `maxPrice` ...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Avoid assignments in expressions** The line contains assignments within an expression, which can make the code harder to read and maintain. Consider separating the a...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Improve `trimDecimals` function to handle all cases** The current implementation of `trimDecimals` might not handle all cases correctly. For example, it would fail f...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider breaking down the hook for better maintainability.** The `useCreatePositionForm` hook is quite large and complex, handling multiple responsibi...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Improve type safety and readability of `numberExponentToLarge` function** The `numberExponentToLarge` function could benefit from improved type safety ...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider additional optimizations and error handling** While the component is well-structured, consider the following improvements: 1. Memoize the `Co...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Clean up code and optimize handlers** 1. Remove the commented-out code for `onMoveMax` and `onMoveMin` if it's no longer needed. 2. Implement proper fu...
coderabbitai[bot] created a review on a pull request on oraichain/oraiswap-frontend
**Actionable comments posted: 11** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>src/pages/Pool-V3/hooks/useCreatePositionForm.ts (1)</...
coderabbitai[bot] created a review on a pull request on oraichain/oraiswap-frontend
**Actionable comments posted: 11** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>src/pages/Pool-V3/hooks/useCreatePositionForm.ts (1)</...
sonarcloud[bot] created a comment on a pull request on oraichain/oraiswap-frontend
## [](https://sonarcloud.io/dashboard?id=...
vuonghuuhung pushed 1 commit to feat/new-v3 oraichain/oraiswap-frontend
- fix error with decimal diff and exponential number ae305cb
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Refactor to eliminate code duplication.** The `getHistoricalPriceDataInDay` function is almost identical to `getHistoricalPriceDataInHour`, leading to ...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider refactoring for improved maintainability and error handling.** The `getHistoricalPriceDataInHour` function is well-structured but quite comple...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Potential logic error in price range calculation.** In the condition `if (minPrice !== 0 || maxPrice !== 0)`, using `||` means the block executes if either `minPrice...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Improve `trimDecimals` function to handle all cases.** The current implementation of `trimDecimals` might not handle all cases correctly. For example, ...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider grouping related items in the return object for better organization.** The hook returns a large number of variables and functions, which can m...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider breaking down the hook for better maintainability.** The `useCreatePositionForm` hook handles a significant amount of functionality and state ...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider refactoring option handling functions to reduce duplication.** The `handleOptionWide` and `handleOptionNarrow` functions have similar structur...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider optimizing the `setIsXToY` reducer.** The `setIsXToY` reducer performs multiple state updates. To improve performance and reduce the risk of i...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider extracting pool initialization logic.** This useEffect hook handles pool initialization. Consider extracting this logic into a separate functi...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider refactoring the `setLiquidityChartData` reducer for improved readability and maintainability.** The `setLiquidityChartData` reducer is quite c...
coderabbitai[bot] created a review on a pull request on oraichain/oraiswap-frontend
**Actionable comments posted: 10** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>src/pages/Pool-V3/hooks/useCreatePositionForm.ts (1)</...