Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review on a pull request on oraichain/oraiswap-frontend
**Actionable comments posted: 10** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>src/pages/Pool-V3/hooks/useCreatePositionForm.ts (1)</...
sonarcloud[bot] created a comment on a pull request on oraichain/oraiswap-frontend
## [](https://sonarcloud.io/dashboard?id=...
vuonghuuhung pushed 7 commits to develop-v3 oraichain/oraiswap-frontend
- update dark mode 8e44a53
- Merge branch 'feat/new-v3' of https://github.com/oraichain/oraiswap-frontend into feat/new-v3 4b10fd6
- update logo 86bf4a0
- update logo 104f465
- fix ui of pool no liquid 686d359
- Merge branch 'feat/new-v3' of https://github.com/oraichain/oraiswap-frontend into feat/new-v3 58d8e05
- resolve 7416a16
vuonghuuhung pushed 2 commits to feat/new-v3 oraichain/oraiswap-frontend
sonarcloud[bot] created a comment on a pull request on oraichain/oraiswap-frontend
## [](https://sonarcloud.io/dashboard?id=...
sonarcloud[bot] created a comment on a pull request on oraichain/oraiswap-frontend
## [](https://sonarcloud.io/dashboard?id=...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Invoke 'callBackFailed' when an error occurs in 'addLiquidity'** In the `addLiquidity` function, if an error occurs during `handleInitPosition`, the error is logged ...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Use 'Number.isNaN' instead of 'isNaN' to avoid type coercion** Using the global `isNaN` function can lead to unexpected results due to type coercion. `Number.isNaN` ...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Include 'null' in the type definition of 'focusId'** The state variable `focusId` is initialized with `null`, but its type is declared as `'zap' | 'x' | 'y'`. To pre...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Resolve TypeScript error instead of using '@ts-ignore'** Using `// @ts-ignore` suppresses TypeScript errors, which might hide underlying issues. The `strokeWidth` pr...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Fix conditional checks to correctly handle zero values for 'min' and 'max'** The current conditional checks for `min` and `max` in the `onMoveMinBoundary` and `onMov...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **[Issue: Incorrect Condition and Potential Division by Zero]** In the calculation of the percentage change for the maximum current price, the condition checks if `lef...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Remove unnecessary console.log statement** The `console.log` statement in `onMoveMaxBoundary` appears to be leftover from debugging and should be removed to clean up...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **[Refactor Suggestion: Duplicate Token Pair Display Logic]** The logic for displaying the token pair is duplicated in both the "Min Price" and "Max Pric...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **[Issue: Potential Division by Zero in Percentage Calculation]** The calculation for the percentage change of the minimum current price may cause a division by zero e...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Implement `onMoveMax` and `onMoveMin` handlers or remove if unnecessary** Currently, `onMoveMax` and `onMoveMin` are assigned empty functions. If these handlers are ...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Memoize `onSubmitMin` handler to prevent unnecessary re-renders** Defining the `onSubmitMin` handler inline causes a new function to be created on ever...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Memoize `onSubmitMax` handler to prevent unnecessary re-renders** Defining the `onSubmitMax` handler inline creates a new function on every render, whi...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider enhancing error handling.** The current error handling approach of logging the error and returning an empty data array is consistent across bo...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider refactoring to reduce duplication.** The `getHistoricalPriceDataInDay` function is almost identical to `getHistoricalPriceDataInHour`, leading...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider optimizing the setLiquidityChartData reducer.** The `setLiquidityChartData` reducer is quite complex and performs a lot of calculations. Consi...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Consider using color variables for consistency** The `.introZap` and `.errorZap` classes use hard-coded rgba values for colors. To improve maintainabil...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Use JSX children instead of the children prop.** The static analysis tool correctly flagged an issue with passing children as a prop. In React, it's preferred to use...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Use theme variables for colors** The `tokenOutput` class and its nested elements use several hard-coded color values. To maintain consistency with the ...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:warning: Potential issue_ **Improve accessibility for disabled state** The current implementation of the disabled state using opacity and blur may not be sufficient for accessibility purposes. ...
coderabbitai[bot] created a review comment on a pull request on oraichain/oraiswap-frontend
_:hammer_and_wrench: Refactor suggestion_ **Improve type safety for the `annotations` prop.** The `annotations` prop uses a ternary operator with type assertion (`as any`). This bypasses TypeScri...
coderabbitai[bot] created a review on a pull request on oraichain/oraiswap-frontend
**Actionable comments posted: 31** <details> <summary>🧹 Outside diff range and nitpick comments (42)</summary><blockquote> <details> <summary>src/pages/Pool-V3/components/HistoricalChartDataWrapp...
coderabbitai[bot] created a review on a pull request on oraichain/oraiswap-frontend
**Actionable comments posted: 31** <details> <summary>🧹 Outside diff range and nitpick comments (42)</summary><blockquote> <details> <summary>src/pages/Pool-V3/components/HistoricalChartDataWrapp...