Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
aivanov-jdk created a review comment on a pull request on openjdk/jdk
The test below `Test4683761.java` removes the `@author` tag. Should it be removed here?
aivanov-jdk created a review comment on a pull request on openjdk/jdk
Copyright years need updating.
aivanov-jdk created a review comment on a pull request on openjdk/jdk
Copyright year needs updating.
cl4es created a comment on a pull request on openjdk/jdk
Yes, that's typically what we do in testing, the subtle problem solved by this is that when you do so you'll silently overwrite pre-existing jvmArgsAppend annotation. I think the suggested scheme i...
shipilev created a comment on a pull request on openjdk/jdk
On various tests on x86_64, this gives me +1% faster runs in `-Xcomp` scenarios. Not very visible with "normal" amount of C2 compilations. ``` ## HelloWorld, -Xcomp -XX:-TieredCompilation #...
openjdk[bot] created a comment on a pull request on openjdk/jdk
@shipilev The following label will be automatically applied to this pull request: - `hotspot-compiler` When this pull request is ready to be reviewed, an "RFR" email will be sent to the correspon...
openjdk[bot] created a comment on a pull request on openjdk/jdk
❗ This change is not yet ready to be integrated. See the **Progress** checklist in the description for automated requirements. <!-- PullRequestBot merge is ready comment --> <!-- PullRequestBot pla...
bridgekeeper[bot] created a comment on a pull request on openjdk/jdk
<!-- Welcome message --> :wave: Welcome back shade! A progress list of the required criteria for merging this PR into `master` will be added to the body of your pull request. There are additional ...
shipilev opened a draft pull request on openjdk/jdk
8342975: C2: Micro-optimize PhaseIdealLoop::Dominators()
Noticed this while looking at Leyden profiles. C2 seems to spend considerable time doing in this loop. The disassembly shows this loop is fairly hot. Replacing the initialization with memset, while...
seanjmullan created a comment on a pull request on openjdk/jdk
Please hold off on integrating until someone from the Security group reviews this.
openjdk-notifier[bot] created a branch on openjdk/jdk
pr/21689 - JDK main-line development https://openjdk.org/projects/jdk
mlbridge[bot] created a comment on a pull request on openjdk/jdk
<!-- mlbridge webrev comment --> <!-- mlbridge webrev header --> ### Webrevs <!-- mlbridge webrev list --> * 00: [Full](https://webrevs.openjdk.org/?repo=jdk&pr=21689&range=00) ([563625d9](https:/...
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- Jmerge command reply message (2435781331) --> @TheRealMDoerr `reinrich` was not found in the census. Syntax: `/contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]`. Fo...
openjdk[bot] created a comment on a pull request on openjdk/jdk
@pejovica The following label will be automatically applied to this pull request: - `build` When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailin...
JornVernee created a review on a pull request on openjdk/jdk
I think I prefer your idea of keeping the code inside `CodeWriter`. Maybe have a `write` and a `writeVerbose`, and have a private method with a `boolean` param that controls printing of extra info?
JornVernee created a review comment on a pull request on openjdk/jdk
Please don't continue the old practice of naming tests after their bug ID. It obfuscates which test class does what (both in the source code and in the test logs). Suggestion for name: `TestStackMa...
JornVernee created a review comment on a pull request on openjdk/jdk
Could you put a comment here that roughly shows what the expected output looks like? I think it would help readers understand what the following three lines are looking for.
JornVernee created a review on a pull request on openjdk/jdk
I think I prefer your idea of keeping the code inside code writer. Maybe have a `write` and a `writeVerbose`, and have a private method with a `boolean` param that controls printing of extra info?
JornVernee created a review on a pull request on openjdk/jdk
I think I prefer your idea of keeping the code inside code writer. Maybe have a `write` and a `writeVerbose`, and have a private method with a `boolean` param that controls printing of extra info?
bridgekeeper[bot] created a comment on a pull request on openjdk/jdk
<!-- Welcome message --> :wave: Welcome back apejovic! A progress list of the required criteria for merging this PR into `master` will be added to the body of your pull request. There are addition...
pejovica opened a pull request on openjdk/jdk
8342974: Inconsistent building of static JDK libraries
This PR addresses an inconsistency in the building of static JDK libraries on Linux when using Clang.
liach created a review comment on a pull request on openjdk/jdk
Does bootcycle fail if this enum constant is removed?
JoeWang-Java created a review on a pull request on openjdk/jdk
Thanks Iris for the reminder. Changes to java.xml look good.
