Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
openjdk-notifier[bot] commented on a commit on openjdk/jdk
<!-- COMMIT COMMENT NOTIFICATION --> ### Review - [openjdk/jdk/21371](https://git.openjdk.org/jdk/pull/21371) ### Issues - [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566)
aivanov-jdk created a comment on a pull request on openjdk/jdk
> I will migrate some ExtendedRobot methods to Robot Are you saying you'll add *new public* methods to `java.awt.Robot`?
hns created a comment on a pull request on openjdk/jdk
@valeriepeng I added two more `@spec` tags as suggested by your feedback (the ones I felt confident about). I'm also uploading new API docs with the "External Specifications" page here: https:...
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- Jmerge command reply message (2435470372) --> @liach @mkarg Pushed as commit 3c14c2babbdfb46a77636ed80e083ef2f8be2b45. :bulb: You may see a message that your pull request was closed with unme...
openjdk[bot] closed a pull request on openjdk/jdk
8341566: Add Reader.of(CharSequence)
This Pull Requests proposes an implementation for [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new method `public static Reader Reader.of(CharSequence)` will return an ano...openjdk[bot] pushed 1 commit to master openjdk/jdk
- 8341566: Add Reader.of(CharSequence) Reviewed-by: rriggs, jpai, liach, alanb 3c14c2b
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- prepush 3c14c2babbdfb46a77636ed80e083ef2f8be2b45 --> Going to push as commit 3c14c2babbdfb46a77636ed80e083ef2f8be2b45. Since your change was applied there have been 270 commits pushed to the `...
aivanov-jdk created a review comment on a pull request on openjdk/jdk
Is anything else but `ExtendedRobot` used from `/lib/client`? If not, remove it.
aivanov-jdk created a review comment on a pull request on openjdk/jdk
Does the test use anything except `ExtendedRobot`? If not, remove `@library`.
aivanov-jdk created a review comment on a pull request on openjdk/jdk
```suggestion return new Robot(); ``` Can be inlined?
aivanov-jdk created a review comment on a pull request on openjdk/jdk
I would let the exception fail the test if it's run on anything but Windows. The test has `@requires (os.family == "windows")`.
aivanov-jdk created a review comment on a pull request on openjdk/jdk
This is wrong — if the test can't create `Robot`, let it fail right away. ```suggestion } catch (Exception ex) { throw new Error("Can't create Robot", ex); } ```
aivanov-jdk created a review comment on a pull request on openjdk/jdk
```suggestion SwingUtilities.invokeAndWait(bug6725409::setupUIStep1); ``` Since you're still updating these lines, I'm for using method references (in all the cases).
aivanov-jdk created a review comment on a pull request on openjdk/jdk
Perhaps, throwing `jtreg.SkippedException` is a better option. Now skipped tests are distinguished from passed ones.
aivanov-jdk created a review comment on a pull request on openjdk/jdk
~~I'd rather keep them aligned as they are — easier to read.~~ Shall we remove this at all? The test is automatic, isn't it? No one will see these messages unless the test fails. [The instruc...
liach created a comment on a pull request on openjdk/jdk
Thanks Markus! The java.io tests succeed with repeats and the only test failures in tier 1-3 were ones problem-listed by f7a61fce949ea2d15ec09d295c643d0c2eabea1e. FYI, besides Kevin's question, ...
openjdk-notifier[bot] pushed 1 commit to pr/21326 openjdk/jdk
- Add @spec tags as per review feedback 7f4a602