Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- Jmerge command reply message (2435470372) --> @liach @mkarg Pushed as commit 3c14c2babbdfb46a77636ed80e083ef2f8be2b45. :bulb: You may see a message that your pull request was closed with unme...
openjdk[bot] closed a pull request on openjdk/jdk
8341566: Add Reader.of(CharSequence)
This Pull Requests proposes an implementation for [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new method `public static Reader Reader.of(CharSequence)` will return an ano...
openjdk[bot] pushed 1 commit to master openjdk/jdk
- 8341566: Add Reader.of(CharSequence) Reviewed-by: rriggs, jpai, liach, alanb 3c14c2b
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- prepush 3c14c2babbdfb46a77636ed80e083ef2f8be2b45 --> Going to push as commit 3c14c2babbdfb46a77636ed80e083ef2f8be2b45. Since your change was applied there have been 270 commits pushed to the `...
aivanov-jdk created a review comment on a pull request on openjdk/jdk
Is anything else but `ExtendedRobot` used from `/lib/client`? If not, remove it.
aivanov-jdk created a review comment on a pull request on openjdk/jdk
Does the test use anything except `ExtendedRobot`? If not, remove `@library`.
aivanov-jdk created a review comment on a pull request on openjdk/jdk
```suggestion return new Robot(); ``` Can be inlined?
aivanov-jdk created a review comment on a pull request on openjdk/jdk
I would let the exception fail the test if it's run on anything but Windows. The test has `@requires (os.family == "windows")`.
aivanov-jdk created a review comment on a pull request on openjdk/jdk
This is wrong — if the test can't create `Robot`, let it fail right away. ```suggestion } catch (Exception ex) { throw new Error("Can't create Robot", ex); } ```
aivanov-jdk created a review comment on a pull request on openjdk/jdk
```suggestion SwingUtilities.invokeAndWait(bug6725409::setupUIStep1); ``` Since you're still updating these lines, I'm for using method references (in all the cases).
aivanov-jdk created a review comment on a pull request on openjdk/jdk
Perhaps, throwing `jtreg.SkippedException` is a better option. Now skipped tests are distinguished from passed ones.
aivanov-jdk created a review comment on a pull request on openjdk/jdk
~~I'd rather keep them aligned as they are — easier to read.~~ Shall we remove this at all? The test is automatic, isn't it? No one will see these messages unless the test fails. [The instruc...
liach created a comment on a pull request on openjdk/jdk
Thanks Markus! The java.io tests succeed with repeats and the only test failures in tier 1-3 were ones problem-listed by f7a61fce949ea2d15ec09d295c643d0c2eabea1e. FYI, besides Kevin's question, ...
openjdk-notifier[bot] pushed 1 commit to pr/21326 openjdk/jdk
- Add @spec tags as per review feedback 7f4a602
AlanBateman created a review comment on a pull request on openjdk/jdk
I have the changes to Class/ClassLoader to propose as soon as this JEP integrates. If that can go in quickly then it would remove any concerns in advance of your cleanup to remove the filtering of ...
AlanBateman created a comment on a pull request on openjdk/jdk
Changing it to use nanoTime is good but I wonder about the reliability of the select(2000) taking >= 1s. This test has a history of being on and off the exclude list several times over the years.
TheShermanTanker created a comment on a pull request on openjdk/jdk
> > the way I did it I'd have to force push > > That should not be the case. You can just anti-delta changes. I did it in a really inefficient way, by checking out all files except for the fi...
JornVernee created a review on a pull request on openjdk/jdk
Latest version looks good. P.S. Oh, looks like the tab I had open for this PR wasn't updated. Didn't see it was already merged. All good!
openjdk-notifier[bot] pushed 2 commits to pr/21651 openjdk/jdk
openjdk-notifier[bot] created a branch on openjdk/jdk
pr/21684 - JDK main-line development https://openjdk.org/projects/jdk
jatin-bhateja created a review comment on a pull request on openjdk/jdk
Please note this test was added just to cover scalar operation validation in VectorMath, automated tests exercise these APIs in fallback implementation anyways.
