Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
openjdk-notifier[bot] created a branch on openjdk/jdk
pr/21677 - JDK main-line development https://openjdk.org/projects/jdk
stefank created a review comment on a pull request on openjdk/jdk
Small, drive-by comment. The rename to `has_owner_anonymous` sounds worse than the previous `is_owner_anonymous` name. I think the code reads better if you change it to `has_anonymous_owner`.
openjdk[bot] created a comment on a pull request on openjdk/jdk
@tschatzl The following label will be automatically applied to this pull request: - `hotspot` When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mail...
openjdk[bot] created a comment on a pull request on openjdk/jdk
❗ This change is not yet ready to be integrated. See the **Progress** checklist in the description for automated requirements. <!-- PullRequestBot merge is ready comment --> <!-- PullRequestBot pla...
bridgekeeper[bot] created a comment on a pull request on openjdk/jdk
<!-- Welcome message --> :wave: Welcome back tschatzl! A progress list of the required criteria for merging this PR into `master` will be added to the body of your pull request. There are addition...
tschatzl opened a pull request on openjdk/jdk
8342939
Hi all, please review this change that makes ZGC compile without the C2 compiler. The solution is to ifdef the offending C2 code, and returning `false` for the predicate that checks whether...
mlbridge[bot] created a comment on a pull request on openjdk/jdk
<!-- Bridged id (Q0FMNWJSdF9GdlF0QmNFMFdqc3dlMnJYcyswOFJNK3ltcndqeGZSODMxY0pkX2ZpZ1p3QG1haWwuZ21haWwuY29t) --> *Mailing list message from [Olexandr Rotan](mailto:[email protected]) on [cor...
AlanBateman created a review comment on a pull request on openjdk/jdk
It's very similar to the "Reference Handler" thread. That thread calls into the VM to get the pending-Reference list. Now we have "VirtualThread-unblocker" calling into the VM to get the list of vi...
rwestrel created a comment on a pull request on openjdk/jdk
Thanks @TobiHartmann for the test results. For the failure in compiler/escapeAnalysis/TestMissingAntiDependency.java I already filed JDK-8341976. I will work on the other ones.
dholmes-ora created a comment on a pull request on openjdk/jdk
I will submit this to our CI to see if we can verify it on the macMini
rose00 created a review on a pull request on openjdk/jdk
I read it through again. Some stylistic issues we have discussed can be saved for later. I didn't find any new problems, and known old problems are addressed. Ship it!
AlanBateman created a review comment on a pull request on openjdk/jdk
Right, although you might have to wait until there is more cleanup in the JDK code before they disappear completely. To clarify, most uses of privileged actions are only done when a SecurityManager...
dholmes-ora created a comment on a pull request on openjdk/jdk
> the way I did it I'd have to force push That should not be the case. You can just anti-delta changes.
XueleiFan created a comment on a pull request on openjdk/jdk
> > > Does it happen in server side (server send plaintext) as well? I found some cases that the client decryption failed. > > > > > > Current reports indicate it happens on the server side on...
XueleiFan created a review comment on a pull request on openjdk/jdk
Is BadPaddingException still good enough for alert messages? Is the description accuracy for both client and server cases?
AlanBateman created a review comment on a pull request on openjdk/jdk
JFR. We haven't changed anything there, just the initial tid.
mlbridge[bot] created a comment on a pull request on openjdk/jdk
<!-- mlbridge webrev comment --> <!-- mlbridge webrev header --> ### Webrevs <!-- mlbridge webrev list --> * 00: [Full](https://webrevs.openjdk.org/?repo=jdk&pr=20953&range=00) ([c6628d30](https:/...
openjdk-notifier[bot] created a branch on openjdk/jdk
pr/20953 - JDK main-line development https://openjdk.org/projects/jdk
eme64 created a review comment on a pull request on openjdk/jdk
Also: all of these cases load, and directly store again. Does that not mean all tests will probably pick the "..._mem" backend operations? Or do we actually end up testing all backend operations wi...
eme64 created a review comment on a pull request on openjdk/jdk
Not sure I see this right. But are we only providing these 4 constants as inputs, and all values in the input arrays will be identical? If that is true: we should have some random inputs, or at lea...
eme64 created a review comment on a pull request on openjdk/jdk
Do equivalent store operations exist we could also match for?
eme64 created a review comment on a pull request on openjdk/jdk
I think this does not check if the generated vectors are too long. We had bugs in the past where we should have created say 2-element vectors, but the backend wrongly created 4-element vectors. Thi...
eme64 created a review comment on a pull request on openjdk/jdk
Ok, now we have 4 or 5 hand-crafted examples. Is that sufficient? Some random values would be nice, then we know that at least eventually we have full coverage.
eme64 created a review on a pull request on openjdk/jdk
Ok, now it looks better. I would still have preferred the `VectorMath` class with its test to be in a separate PR. Please do that next time. I have a few more questions / comments, but we are...