Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
eme64 created a review comment on a pull request on openjdk/jdk
Also: all of these cases load, and directly store again. Does that not mean all tests will probably pick the "..._mem" backend operations? Or do we actually end up testing all backend operations wi...
eme64 created a review comment on a pull request on openjdk/jdk
Not sure I see this right. But are we only providing these 4 constants as inputs, and all values in the input arrays will be identical? If that is true: we should have some random inputs, or at lea...
eme64 created a review comment on a pull request on openjdk/jdk
Do equivalent store operations exist we could also match for?
eme64 created a review comment on a pull request on openjdk/jdk
I think this does not check if the generated vectors are too long. We had bugs in the past where we should have created say 2-element vectors, but the backend wrongly created 4-element vectors. Thi...
eme64 created a review comment on a pull request on openjdk/jdk
Ok, now we have 4 or 5 hand-crafted examples. Is that sufficient? Some random values would be nice, then we know that at least eventually we have full coverage.
eme64 created a review on a pull request on openjdk/jdk
Ok, now it looks better. I would still have preferred the `VectorMath` class with its test to be in a separate PR. Please do that next time. I have a few more questions / comments, but we are...
eme64 created a review on a pull request on openjdk/jdk
Ok, now it looks better. I would still have preferred the `VectorMath` class with its test to be in a separate PR. Please do that next time. I have a few more questions / comments, but we are...
plummercj created a review comment on a pull request on openjdk/jdk
I would just remove the static. I don't see any reason for it to exist.
TobiHartmann created a comment on a pull request on openjdk/jdk
More failures: ``` compiler/loopopts/TestOverunrolling.java -XX:-TieredCompilation -XX:+AlwaysIncrementalInline # A fatal error has been detected by the Java Runtime Environment: # # Int...
openjdk-notifier[bot] commented on a commit on openjdk/jdk
<!-- COMMIT COMMENT NOTIFICATION --> ### Review - [openjdk/jdk/20990](https://git.openjdk.org/jdk/pull/20990) ### Issues - [JDK-8339296](https://bugs.openjdk.org/browse/JDK-8339296)
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- Jmerge command reply message (2434430728) --> @lahodaj Pushed as commit f0b130e54f33d3190640ce33c991e35f27e9f812. :bulb: You may see a message that your pull request was closed with unmerged ...
openjdk[bot] closed a pull request on openjdk/jdk
8339296: Record deconstruction pattern in switch fails to compile
Consider code like this: ``` int nestedSwitchesInArgumentPosition(Object o1) { return id(switch (o1) { case R(var o2) -> switch (o2) { case R(String s) ...
openjdk[bot] pushed 1 commit to master openjdk/jdk
- 8339296: Record deconstruction pattern in switch fails to compile Reviewed-by: vromero, mcimadamore f0b130e
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- prepush f0b130e54f33d3190640ce33c991e35f27e9f812 --> Going to push as commit f0b130e54f33d3190640ce33c991e35f27e9f812. Since your change was applied there have been 651 commits pushed to the `...
openjdk-notifier[bot] pushed 149 commits to pr/21431 openjdk/jdk
- 8341637: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64) ... ba3774d
- 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 Reviewed-by: l... f56a154
- 8342002: sun/security/tools/keytool/GenKeyPairSigner.java failed due to missing certificate output Reviewed-by: mullan 9e262df
- 8341831: PhaseCFG::insert_anti_dependences asserts with "no loads" Reviewed-by: dlong, kvn a8a8b2d
- 8339879: Open some dialog awt tests Reviewed-by: honkar, prr 6071346
- 8317356: Fix missing null checks in the ClassFile API Co-authored-by: Nizar Benalla <[email protected]> Reviewed-... a2c7752
- 8341924: Improve error message with structurally malformed Code array Reviewed-by: asotona bd62644
- 8342014: RISC-V: ZStoreBarrierStubC2 clobbers rflags Reviewed-by: rehn, aboldtch, mli a601cd2
- 8337851: Some tests have name which confuse jtreg Reviewed-by: aivanov, prr, cstein e6698f5
- 8340189: 8339531 incorrect for Big Endian platforms Reviewed-by: mdoerr, amitkumar 521effe
- 8337269: G1ConfidencePercent interpreted inconsistently Reviewed-by: kbarrett, iwalulya 3b8a2f8
- 8338596: Clarify handling of restricted and caller-sensitive methods Co-authored-by: Hannes Wallnöfer <hannesw@openj... f4dccfd
- 8337339: gc/arguments/Test*SizeFlags.java timing out with Xcomp Reviewed-by: shade, iwalulya c9a536c
- 8338603: DiagnosticCommandMBean operations should standardize types for parameters Reviewed-by: cjplummer, egahlin df7d6e0
- 8302111: Serialization considerations Reviewed-by: skoivu, rhalade, weijun, wetmore 369c573
- 8328726: Better Kerberos support Reviewed-by: ahgross, rhalade, valeriep, coffeys 893e7bc
- 8328286: Enhance HTTP client Reviewed-by: aefimov, michaelm 03bc6b3
- 8328544: Improve handling of vectorization Co-authored-by: Christian Hagedorn <[email protected]> Reviewed-by: m... cfa25b7
- 8311208: Improve CDS Support Reviewed-by: rhalade, mschoene, ccheung, iklam 498a582
- 8307383: Enhance DTLS connections Co-authored-by: Jamil Nimeh <[email protected]> Reviewed-by: rhalade, mschoene, a... dadcee1
- and 129 more ...
eme64 created a review comment on a pull request on openjdk/jdk
Also: why did we not add these `Long.minUnsigned` etc? I guess that was already discussed? Because we can easily also use this with the auto-vectorizer or more generally. Saturating and unsigned o...
eme64 created a review comment on a pull request on openjdk/jdk
I think this class could have been split into a separate RFE, together with its tests. I would prefer that next time.
TobiHartmann created a comment on a pull request on openjdk/jdk
> What Hank has done in this PR is to test each instruction with random register, address, and immediate instead of all the combinations that he had before so we still have a decent coverage. The t...
eme64 created a review comment on a pull request on openjdk/jdk
Nit: above you always have `add` and `sub` in the name and the `format`. I and here and in some cases below not. Would be nice if it was consistent - would also make reading the OptoAssembly easier...
dholmes-ora created a review comment on a pull request on openjdk/jdk
Right I understand we can't store the BasicLock* directly in owner, but the naming of this method has me confused as to what it actually does. With the old version we have: Before: owner = Basic...
rose00 created a comment on a pull request on openjdk/jdk
A thought for a possible cleanup, after this PR is done… The scratch mirror logic had me… scratching my head. It seems to me that a more descriptive name would make the code explain itself bett...
dholmes-ora created a review comment on a pull request on openjdk/jdk
I had expected to see a call to a new `wait0` method that returned a value indicating whether the wait was completed or else we had to park. Instead we had to put special logic in the native-call-w...