Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
openjdk-notifier[bot] commented on a commit on openjdk/jdk
<!-- COMMIT COMMENT NOTIFICATION --> ### Review - [openjdk/jdk/21646](https://git.openjdk.org/jdk/pull/21646) ### Issues - [JDK-8342854](https://bugs.openjdk.org/browse/JDK-8342854)
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- Jmerge command reply message (2433322230) --> @dougxc Pushed as commit 98403b75df0a0737bdf082231f38c5c0019fe4c9. :bulb: You may see a message that your pull request was closed with unmerged c...
openjdk[bot] closed a pull request on openjdk/jdk
8342854: [JVMCI] Block secondary thread reporting a JVMCI fatal error
A fatal crash on a second thread causes the thread to [sleep infinitely](https://github.com/openjdk/jdk/blob/d6eddcdaf92f2352266ba519608879141997cd63/src/hotspot/share/utilities/vmError.cpp#L1709-L...
openjdk[bot] pushed 1 commit to master openjdk/jdk
- 8342854: [JVMCI] Block secondary thread reporting a JVMCI fatal error Reviewed-by: never 98403b7
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- prepush 98403b75df0a0737bdf082231f38c5c0019fe4c9 --> Going to push as commit 98403b75df0a0737bdf082231f38c5c0019fe4c9. Since your change was applied there have been 445 commits pushed to the `...
openjdk-notifier[bot] pushed 1 commit to pr/21577 openjdk/jdk
- Remove duplicate description from docs 7d0a8b7
mrserb created a review comment on a pull request on openjdk/jdk
You can change the CHECK_EXCEPTION_FATAL macro to something like ``` #define CHECK_EXCEPTION_FATAL(env, message) \ if ((*env)->ExceptionCheck(env)) { \ (*env)->ExceptionDescribe(env...
mpdonova created a review comment on a pull request on openjdk/jdk
can clean this a little bit with ``` return switch(primeSize) { case 2048 -> DiffieHellmanGroup.ffdhe2048; case 3072 -> DiffieHellmanGroup.ffdhe3072; case 4096 -> DiffieHellmanGr...
mpdonova created a review comment on a pull request on openjdk/jdk
Why not just ``` DHParameterSpec dhParamSpec = new DHParameterSpec(dhGroup.getPrime(), dhGroup.getBase()); System.err.println("Using " + dhGroup.name() + " Diffie-Hellman parameters"); ``` I...
mpdonova created a review comment on a pull request on openjdk/jdk
don't need fully qualified names here.
openjdk-notifier[bot] pushed 1 commit to pr/21577 openjdk/jdk
- Re-ordering and simplifying the checks. Restricting new constraint to TLS. Updating docs. 85c4a16
rhalade created a review comment on a pull request on openjdk/jdk
Using current directory here may be incorrect. Can this be changed to `Path.of(System.getProperty("test.classes"), ".")`
rhalade created a review comment on a pull request on openjdk/jdk
Check jdk.test.lib if there is a method you can use to copy files. If not then this method should be added to library.
blperez01 created a review comment on a pull request on openjdk/jdk
Some of these values are constants in the spec and others are commonly used values derived from the constants. For example, `s1PackedLength = (mlDsa_l * (eta + 1) * 256) / 8` because the vector `s1...
plummercj created a review comment on a pull request on openjdk/jdk
I think you can use getSizet() here.
openjdk-notifier[bot] commented on a commit on openjdk/jdk
<!-- COMMIT COMMENT NOTIFICATION --> ### Review - [openjdk/jdk/21628](https://git.openjdk.org/jdk/pull/21628) ### Issues - [JDK-8341939](https://bugs.openjdk.org/browse/JDK-8341939)
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- Jmerge command reply message (2433289730) --> @sashamatveev Pushed as commit 9a7a850e2892990cf6755a0ccb19711816ad1b51. :bulb: You may see a message that your pull request was closed with unme...
openjdk[bot] closed a pull request on openjdk/jdk
8341939: SigningOptionsTest fails without Xcode with command line developer tools after JDK-8341443
- Removed hard check for "Xcode with command line developer tools" when `--mac-sign` is specified and instead we will show information message if `codesign` fails for any reason that possible root ...
openjdk[bot] pushed 1 commit to master openjdk/jdk
- 8341939: SigningOptionsTest fails without Xcode with command line developer tools after JDK-8341443 Reviewed-by: ase... 9a7a850
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- prepush 9a7a850e2892990cf6755a0ccb19711816ad1b51 --> Going to push as commit 9a7a850e2892990cf6755a0ccb19711816ad1b51. Since your change was applied there have been 34 commits pushed to the `m...
jyxzwd closed a pull request on openjdk/jdk
8331467: ImageReaderFactory can cause a ClassNotFoundException if the default FileSystemProvider is not the system-default provider
Use the built-in file system provider rather than the custom file system provider. Add "public static FileSystemProvider create" method in DefaultFileSystemProvider which is from java8API to be co...