Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mpdonova created a review comment on a pull request on openjdk/jdk
It looks like the DiffieHelmanGroup fields are just used to intialize the DHParameterSpec. It might be cleaner to create the DHParameterSpec objects in a static initializer. Also, the DHParamet...
honkar-jdk created a review comment on a pull request on openjdk/jdk
@prrace I might have missed removing this check which was in the original test. The latest update to this test has two run tags but it fails when isFileCacheExpected is set to true. Did you mean...
egahlin created a comment on a pull request on openjdk/jdk
> @egahlin / @mgronlun could you please review the JFR parts of this PR? One change is for getting the right prototype header, the other is for avoiding an endless loop/assert in a corner case. ...
openjdk[bot] created a comment on a pull request on openjdk/jdk
@gerard-ziemski The following labels will be automatically applied to this pull request: - `hotspot` - `shenandoah` When this pull request is ready to be reviewed, an "RFR" email will be sent to ...
openjdk[bot] created a comment on a pull request on openjdk/jdk
❗ This change is not yet ready to be integrated. See the **Progress** checklist in the description for automated requirements. <!-- PullRequestBot merge is ready comment --> <!-- PullRequestBot pla...
bridgekeeper[bot] created a comment on a pull request on openjdk/jdk
<!-- Welcome message --> :wave: Welcome back gziemski! A progress list of the required criteria for merging this PR into `master` will be added to the body of your pull request. There are addition...
coleenp created a comment on a pull request on openjdk/jdk
> Why do we need to cache it? Is it the implicit barriers related to accessing the threadObj oop each time? We cache threadObj.thread_id in JavaThread::_lock_id so that the fast path c2_MacroAss...
coleenp created a review comment on a pull request on openjdk/jdk
but you won't see access_controller_klass or priviledged_action_klass frames, so no need to skip them?
openjdk-notifier[bot] commented on a commit on openjdk/jdk
<!-- COMMIT COMMENT NOTIFICATION --> ### Review - [openjdk/jdk/21508](https://git.openjdk.org/jdk/pull/21508) ### Issues - [JDK-8233451](https://bugs.openjdk.org/browse/JDK-8233451)
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- Jmerge command reply message (2433174314) --> @bplb Pushed as commit de92fe375771315452fc5318abfd228fdd31c454. :bulb: You may see a message that your pull request was closed with unmerged com...
openjdk[bot] closed a pull request on openjdk/jdk
8233451: (fs) Files.newInputStream() cannot be used with character special files
Add `isOther` and `available` methods to `FileChannelImpl` and the interfaces to native code and use these in `ChannelInputStream` to work around cases where a wrapped `FileChannelImpl` is not real...
openjdk[bot] pushed 1 commit to master openjdk/jdk
- 8233451: (fs) Files.newInputStream() cannot be used with character special files Reviewed-by: alanb de92fe3
openjdk[bot] created a comment on a pull request on openjdk/jdk
<!-- prepush de92fe375771315452fc5318abfd228fdd31c454 --> Going to push as commit de92fe375771315452fc5318abfd228fdd31c454. Since your change was applied there have been 184 commits pushed to the `...
iklam created a review comment on a pull request on openjdk/jdk
But the code does not do what its name suggests. If this is not required now, I think we should remove the can_load part so the code is not confusing.
mlbridge[bot] created a comment on a pull request on openjdk/jdk
<!-- mlbridge webrev comment --> <!-- mlbridge webrev header --> ### Webrevs <!-- mlbridge webrev list --> * 00: [Full](https://webrevs.openjdk.org/?repo=jdk&pr=21668&range=00) ([ccd129da](https:/...
openjdk-notifier[bot] created a branch on openjdk/jdk
pr/21668 - JDK main-line development https://openjdk.org/projects/jdk
openjdk[bot] created a comment on a pull request on openjdk/jdk
@viktorklang-ora The following label will be automatically applied to this pull request: - `core-libs` When this pull request is ready to be reviewed, an "RFR" email will be sent to the correspon...
openjdk[bot] created a comment on a pull request on openjdk/jdk
❗ This change is not yet ready to be integrated. See the **Progress** checklist in the description for automated requirements. <!-- PullRequestBot merge is ready comment --> <!-- PullRequestBot pla...
bridgekeeper[bot] created a comment on a pull request on openjdk/jdk
<!-- Welcome message --> :wave: Welcome back vklang! A progress list of the required criteria for merging this PR into `jdk23` will be added to the body of your pull request. There are additional ...
