Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
liach created a review comment on a pull request on openjdk/jdk
What does "ell" stand for? Looks like "eel" to me. That aside, if there's no good name, we usually use `that` or `o` for the casted variable, like ``` return obj instanceof Long that && this.val...
bplb created a comment on a pull request on openjdk/jdk
30 repeats on all platforms succeeded also after the most recent commit, 2876d9f.
vnkozlov created a comment on a pull request on openjdk/jdk
"This test is including a huge, generated file `asmtest.out.h`. I'm guessing this is the culprit of the long compile time." May be the test should be compiled conditionally to avoid affect on JV...
jddarcy created a review comment on a pull request on openjdk/jdk
The general intention is that the back-end intrinsification efforts that use native hardware instructions, where present, will provide the main speed boost. Therefore, the preference has been to ke...
openjdk[bot] created a comment on a pull request on openjdk/jdk
@sendaoYan The following label will be automatically applied to this pull request: - `hotspot-jfr` When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding...
openjdk[bot] created a comment on a pull request on openjdk/jdk
❗ This change is not yet ready to be integrated. See the **Progress** checklist in the description for automated requirements. <!-- PullRequestBot merge is ready comment --> <!-- PullRequestBot pla...
bridgekeeper[bot] created a comment on a pull request on openjdk/jdk
<!-- Welcome message --> :wave: Welcome back syan! A progress list of the required criteria for merging this PR into `master` will be added to the body of your pull request. There are additional [...
sendaoYan opened a pull request on openjdk/jdk
8342285: Mark jdk/jfr/api/event/TestIsEnabledMultiple.java as intermittent
Hi all, The test `jdk/jfr/api/event/TestIsEnabledMultiple.java` has been observed intermittent failure several times. I think we should mark this test as intermittent failure. Trivial fix, no risk.
matias9927 created a review comment on a pull request on openjdk/jdk
I left it in since it may be a valuable check in case there are further changes or additions to the GCs.
jddarcy created a review comment on a pull request on openjdk/jdk
Hmm. Certainly at this point, I don't think hash randomization is necessary; although it might be helpful at a later point. Set.of() uses randomized iteration order as a precedent in that direction.
bridgekeeper[bot] closed a pull request on openjdk/jdk
8338931: ZipEntry.flag could be made internal to ZipOutputStream
Please review this refactoring PR which moves the `ZipEntry.flag` field back to `ZipOutputStream.XEntry`. Moving this field will save four bytes from the `ZipEntry` object size and also saves an...
bridgekeeper[bot] created a comment on a pull request on openjdk/jdk
@eirbjo This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen...
reinrich created a comment on a pull request on openjdk/jdk
For the record: the kernel sets the `fpregs` pointer [here](https://github.com/torvalds/linux/blob/eb26cbb1a754ccde5d4d74527dad5ba051808fad/arch/x86/kernel/signal_64.c#L128) :)
jddarcy created a review comment on a pull request on openjdk/jdk
In other place in the code, I've written out "ell" to avoid any confusion between lowercase "l" and a number "1", etc.
jddarcy created a review comment on a pull request on openjdk/jdk
Hi @forax, Yes, I had considered that before sending out the PR. It shouldn't matter from a performance perspective, so it would come to down to which version of the code was marginally easier to ...
magicus created a comment on a pull request on openjdk/jdk
This finally explains the odd problem you reported in https://github.com/openjdk/jdk/pull/20837#issuecomment-2327132241. That has been worrying me a bit, if there were some issue with that PR after...
vnkozlov created a review comment on a pull request on openjdk/jdk
What vectors are generated (or not) with this change? The array in the test ins `int[]` but the element_type will be Long now. Will it bailout vectorization?
TheRealMDoerr created a comment on a pull request on openjdk/jdk
Thanks for your input @reinrich, @tstuefe. I've tried taking the values from `uc->uc_mcontext.fpregs->_xmm[i]`. This seems to work fine if we got a signal. However, "should_not_reach_here()" and fr...
