Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pomegranited created a review on a pull request on openedx/edx-platform
+1: Looks great, thank you @DanielVZ96 ! Note: The problem blank XBlock added by this new button needs https://github.com/openedx/edx-platform/pull/35705 to function properly, but the button loo...
kdmccormick created a comment on a pull request on openedx/edx-platform
The new itembank icon png is currently larger (256x256 pixels) than the other green button icon pngs, which might be why it doesn't fit. Here's it shrunk down to 38x38, which I think looks alrig...
kdmccormick created a review comment on a pull request on openedx/edx-platform
We're not-- that one just is going out to the logs. The users see `str(exc)`, i.e. the BadUpstream exception message, which we've already taken care to localize.
ormsbee created a review comment on a pull request on openedx/edx-platform
Sorry, belatedly occurred to me, but don't we need to translate this string if we're presenting it to end users?
kdmccormick opened a pull request on openedx/edx-platform
fix: Improve messaging & logging when adding Library Content (Beta) fails
We have user-oriented messaging stuffed into the BadUpstream exception. We may as well use it rather than just giving an opaque error about xblock references. We also want to log this situation,...
kdmccormick created a review comment on a pull request on openedx/edx-platform
@DanielVZ96 unlike library_v2, itembank is actually a real XBlock tag (the class is ItemBankBlock), so it'd be fine to let this function return the mixed class. (The only thing that this functio...
kdmccormick created a comment on a pull request on openedx/edx-platform
Ah, right. I do see the icon now, but it it's zoomed in too far. 
DanielVZ96 created a review comment on a pull request on openedx/edx-platform
I'm assuming this is the case for itembank too
DanielVZ96 created a comment on a pull request on openedx/edx-platform
@kdmccormick did you try running `tutor dev exec cms npm run watch`?
kdmccormick created a comment on a pull request on openedx/edx-platform
Testing... With `contentstore.new_studio_mfe.disable_new_libraries` ON:  With `contentstore.new_stu...
ormsbee created a comment on a pull request on openedx/edx-platform
> I was able to create a collision (on the AssetKey level, I believe) by uploading a file to a course named something like `components_html_html1_little-library.png`. It had the effect of clobberin...
kdmccormick created a review on a pull request on openedx/edx-platform
Tested and verified. Code looks good. Thank you, as always, for the helpful comments.
kdmccormick created a review on a pull request on openedx/edx-platform
Tested and verified. Code looks good. Thank you, as always, for the helpful comment.s
kdmccormick created a comment on a pull request on openedx/edx-platform
I was able to create a collision (on the AssetKey level, I believe) by uploading a file to a course named something like `components_html_html1_little-library.png`. It had the effect of clobbering ...
ormsbee created a comment on a pull request on openedx/edx-platform
@kdmccormick: it should be fixed once https://github.com/openedx/frontend-app-authoring/pull/1403 merges
kdmccormick created a comment on a pull request on openedx/edx-platform
@ormsbee when I edit this pasted-in library component:  the editor renders the altext instead of the ...
openedx-webhooks created a comment on a pull request on openedx/edx-platform
Thanks for the pull request, @DanielVZ96! ### What's next? *Please work through the following steps to get your changes ready for engineering review:* #### :radio_button: Get product approval I...
DanielVZ96 opened a draft pull request on openedx/edx-platform
feat: itembank green button
<!-- Note: Please refer to the Support Development Guidelines on the wiki page to consider backporting to active releases: https://openedx.atlassian.net/wiki/spaces/COMM/pages/4248436737/Suppor...
ormsbee created a review comment on a pull request on openedx/edx-platform
BTW, I am absolutely going to accept these suggestions just as soon as CI finishes running.
kdmccormick created a review comment on a pull request on openedx/edx-platform
```suggestion f"file {filename}, but no file data was found." ``` [nit] previous line already has a space
kdmccormick created a review comment on a pull request on openedx/edx-platform
```suggestion ) -> tuple[bool | None, dict]: ```
kdmccormick created a review comment on a pull request on openedx/edx-platform
```suggestion ) -> tuple[StaticFileNotices, dict[str, str]]: ```