Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
navinkarkera created a review comment on a pull request on openedx/edx-platform
We don't need it anymore, it was required when MFE was pushing the block to course. Now it only sends a message with selection details. I'll update it.
bradenmacdonald created a comment on a pull request on openedx/edx-platform
@kdmccormick @navinkarkera @pomegranited FYI
openedx-webhooks created a comment on a pull request on openedx/edx-platform
Thanks for the pull request, @bradenmacdonald! ### What's next? *Please work through the following steps to get your changes ready for engineering review:* #### :radio_button: Get product approv...
openedx-webhooks created a comment on a pull request on openedx/edx-platform
Thanks for the pull request, @bradenmacdonald! ### What's next? *Please work through the following steps to get your changes ready for engineering review:* #### :radio_button: Get product approv...
bradenmacdonald opened a pull request on openedx/edx-platform
"Bare Bones" UI for Problem Bank [FC-0062]
## Description This implements a minimal UI so that [the WIP Problem Bank XBlock](https://github.com/openedx/edx-platform/pull/35553) is usable: https://github.com/user-attachments/assets/093...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
Like this: https://github.com/open-craft/edx-platform/commit/5939b5dada9f44f854d11dbe31ebef313349096a Turns out this is actually necessary or sometimes a random message will come in and use up t...
bradenmacdonald created a comment on a pull request on openedx/edx-platform
@navinkarkera Oh, actually one more important thing: can you make sure this new button is only enabled if [`libraries_v2_enabled()`](https://github.com/openedx/edx-platform/blob/83827a3dc2794a70399...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
Nit: you don't have to check _all_ the fields of `doc` again here. You can just check `doc["display_name"]`, `doc["description"]`, and `doc["published"]`
bradenmacdonald created a review on a pull request on openedx/edx-platform
Thanks, this is great! I tested and it's working well. Just one request: can you please add `published.display_name` and `published.description` to `update_searchable_attributes` in `edx-platfor...
bradenmacdonald created a review on a pull request on openedx/edx-platform
Thanks, this is great! I tested and it's working well. Just one request: can you please add `published.display_name` and `published.description` to `update_searchable_attributes` in `edx-platfor...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
Also if you use an arrow function ```js window.addEventListener("message", (event) => { ``` then you can remove the `.bind(this)` as it won't be necessary.
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
This can be fixed in a fast-follow PR if you want, but it's not a great UX that the "Next" button is sometimes hidden until you scroll, and the Next + Cancel buttons are in totally different places...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
I think you're missing code to remove the event listener if the modal is closed/cancelled without picking a component.
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
```suggestion # Set `created_block.upstream` and then sync this with the upstream (library) version. ``` Why do we care about "preserving the former value of `created_block.upstream`...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
TODO: add a comment that this is not actually an XBlock, unlike the others.
bradenmacdonald created a review on a pull request on openedx/edx-platform
Nice! It's working well. Here are some minor things I've noted that we should clean up:
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
Do we even need to pass `parentLocator` anymore?
bradenmacdonald created a review on a pull request on openedx/edx-platform
Nice! It's working well. Here are some minor things I've noted that we should clean up:
bradenmacdonald created a comment on a pull request on openedx/edx-platform
I also have a draft "published" filter but it turns out to need some backend changes to implement and I haven't had time. CC @ChrisChV . https://github.com/openedx/frontend-app-authoring/pull/1406
ChrisChV created a review comment on a pull request on openedx/edx-platform
Updated: https://github.com/openedx/edx-platform/pull/35596/commits/845f124a85a59ca34cde37bf36c94656cdc0c90f
ChrisChV created a review comment on a pull request on openedx/edx-platform
Updated: https://github.com/openedx/edx-platform/pull/35596/commits/845f124a85a59ca34cde37bf36c94656cdc0c90f
bradenmacdonald created a comment on a pull request on openedx/edx-platform
> It seems like upstream sync will only [support blocks that were published](https://github.com/open-craft/edx-platform/blob/0da35c128f156f99e4ae1d8865fd888c0f95a9cc/cms/lib/xblock/upstream_sync.py...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
No, you can remove this
bradenmacdonald created a comment on a pull request on openedx/edx-platform
This work has been incorporated into https://github.com/openedx/edx-platform/pull/35670 - we'll use that PR.