Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
bradenmacdonald created a review on a pull request on openedx/edx-platform
Nice! It's working well. Here are some minor things I've noted that we should clean up:
bradenmacdonald created a comment on a pull request on openedx/edx-platform
I also have a draft "published" filter but it turns out to need some backend changes to implement and I haven't had time. CC @ChrisChV . https://github.com/openedx/frontend-app-authoring/pull/1406
ChrisChV created a review comment on a pull request on openedx/edx-platform
Updated: https://github.com/openedx/edx-platform/pull/35596/commits/845f124a85a59ca34cde37bf36c94656cdc0c90f
ChrisChV created a review comment on a pull request on openedx/edx-platform
Updated: https://github.com/openedx/edx-platform/pull/35596/commits/845f124a85a59ca34cde37bf36c94656cdc0c90f
bradenmacdonald created a comment on a pull request on openedx/edx-platform
> It seems like upstream sync will only [support blocks that were published](https://github.com/open-craft/edx-platform/blob/0da35c128f156f99e4ae1d8865fd888c0f95a9cc/cms/lib/xblock/upstream_sync.py...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
No, you can remove this
bradenmacdonald created a comment on a pull request on openedx/edx-platform
This work has been incorporated into https://github.com/openedx/edx-platform/pull/35670 - we'll use that PR.
openedx-webhooks created a comment on a pull request on openedx/edx-platform
Thanks for the pull request, @ChrisChV! ### What's next? *Please work through the following steps to get your changes ready for engineering review:* #### :radio_button: Get product approval If ...
ChrisChV opened a pull request on openedx/edx-platform
feat: Store "published display name" and "published description" in s…
…tudio search index <!-- Note: Please refer to the Support Development Guidelines on the wiki page to consider backporting to active releases: https://openedx.atlassian.net/wiki/spaces/COMM/...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
Sure - I pushed a commit with the URL param converter. I don't know if it's any cleaner than just using `version_str`, but I agree that doing one or the other is an improvement. Thx!
ormsbee created a review comment on a pull request on openedx/edx-platform
I like that you're making one of these–I think it really helps clean things up.
ormsbee created a review comment on a pull request on openedx/edx-platform
[Nit, optional]: Per your earlier convention, the `version` param passed into this view could be renamed `version_str` to clarify that it hasn't been parsed yet, or you could create another URL par...
ormsbee created a review on a pull request on openedx/edx-platform
Optional suggestion–not a blocker.
ormsbee created a review on a pull request on openedx/edx-platform
Optional suggestion–not a blocker.
navinkarkera created a review comment on a pull request on openedx/edx-platform
Fixes a typo/bug introduced in https://github.com/openedx/edx-platform/pull/35587
navinkarkera created a review comment on a pull request on openedx/edx-platform
Fixes a typo/bug introduced in https://github.com/openedx/edx-platform/pull/35587
navinkarkera created a review on a pull request on openedx/edx-platform
It seems like upstream sync will only [support blocks that were published](https://github.com/open-craft/edx-platform/blob/0da35c128f156f99e4ae1d8865fd888c0f95a9cc/cms/lib/xblock/upstream_sync.py#L...
navinkarkera created a review on a pull request on openedx/edx-platform
It seems like upstream sync will only [support blocks that were published](https://github.com/open-craft/edx-platform/blob/0da35c128f156f99e4ae1d8865fd888c0f95a9cc/cms/lib/xblock/upstream_sync.py#L...
navinkarkera created a review comment on a pull request on openedx/edx-platform
@kdmccormick Yes, called upstream sync after creating the block in a single call, simplified the js part. https://github.com/openedx/edx-platform/pull/35670/commits/bc27ba347a56a428755038d7289aa269...
CodeWithEmad created a comment on a pull request on openedx/edx-platform
Thanks for mentioning this. My change is related to the old theme, where it forces you to first go to the `authn` mfe if you have it enabled, no matter what. then, from there, it chooses to send yo...
openedx-webhooks created a comment on a pull request on openedx/edx-platform
Thanks for the pull request, @DanielVZ96! ### What's next? *Please work through the following steps to get your changes ready for engineering review:* #### :radio_button: Get product approval I...
DanielVZ96 opened a draft pull request on openedx/edx-platform
Dvz/publish single component
<!-- Note: Please refer to the Support Development Guidelines on the wiki page to consider backporting to active releases: https://openedx.atlassian.net/wiki/spaces/COMM/pages/4248436737/Suppor...
ChrisChV created a comment on a pull request on openedx/edx-platform
I'm sorry. I had to take care of something urgent, and I missed the merge window. I'll merge it first thing Monday morning.