Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ziafazal created a review on a pull request on openedx/edx-platform
@asadali145 thanks for making these changes. Could you please add some unit tests to support these?
ziafazal created a review on a pull request on openedx/edx-platform
@asadali145 thanks for making these changes. Could you please add some unit tests to support these?
openedx-webhooks created a comment on a pull request on openedx/edx-platform
Thanks for the pull request, @pomegranited! ### What's next? *Please work through the following steps to get your changes ready for engineering review:* #### :radio_button: Get product approval ...
pomegranited opened a draft pull request on openedx/edx-platform
feat: add Meilisearch-compatible search engine
**DO NOT MERGE** This PR exists solely to deploy a sandbox for https://github.com/openedx/edx-platform/pull/35650. **Settings** ```yaml EDX_PLATFORM_REPOSITORY: https://github.com/regisb/edx...
pomegranited created a review comment on a pull request on openedx/edx-platform
I guess this is something we can deal with if and when we need to.
jignaciopm created a comment on an issue on openedx/edx-platform
Yes @arbrandes of course. It is [here](https://github.com/openedx/edx-platform/pull/35661). I await your review.
openedx-webhooks created a comment on a pull request on openedx/edx-platform
Thanks for the pull request, @jignaciopm! ### What's next? *Please work through the following steps to get your changes ready for engineering review:* #### :radio_button: Get product approval I...
jignaciopm opened a pull request on openedx/edx-platform
fix: remove error ReferenceError: JavascriptLoader is not defined in Zoom Image Tool
<!-- Note: Please refer to the Support Development Guidelines on the wiki page to consider backporting to active releases: https://openedx.atlassian.net/wiki/spaces/COMM/pages/4248436737/Suppor...
ormsbee created a review comment on a pull request on openedx/edx-platform
Right. I should know better. Is late, brain no-workie good. <sigh>
ormsbee created a review comment on a pull request on openedx/edx-platform
[request] There's a lot of boilerplate in this template, along with stuff we probably don't strictly need (like the hotjar piece). That's okay–this isn't intended to be long-lived, and it's a fast ...
ormsbee created a review comment on a pull request on openedx/edx-platform
[request] Please add a comment explaining why we're doing this.
ormsbee created a review comment on a pull request on openedx/edx-platform
[request] Please add some sort of comment to this file to explain what it is, why it exists, and how it's intended to be different from the template file it's based off of.
ormsbee created a review on a pull request on openedx/edx-platform
Some questions and requests. Nothing major. I don't feel like I can meaningfully review any of the styles though.
ormsbee created a review on a pull request on openedx/edx-platform
Some questions and requests. Nothing major. I don't feel like I can meaningfully review any of the styles though.
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
Err sorry that should be `http://studio.local.openedx.io:8001/` or `http://local.openedx.io:8000/`
ormsbee created a review comment on a pull request on openedx/edx-platform
You know, I think to date it returns a site-relative URL, but I think it makes more sense to return an absolute one, so I'll just do that and see if anything breaks. 😛
ormsbee created a review comment on a pull request on openedx/edx-platform
I'm kind of on the fence about it. When I took a brief sketch at extracting out the common part here, the helper naming and indirection just seemed to add more confusion than it was worth. I don't ...
bradenmacdonald created a comment on a pull request on openedx/edx-platform
> > 1. Is edx-platform the right place to add this module? (I think it is, because edx-search is used only in edx-platform). If yes, did I pick the right location in the edx-platform file hierarchy...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
Nit: I'd recommend moving this code and the code below into a new `_find_static_assets` method or something like that. Or use an explicit `else:` case. I'm just worried that someone might not noti...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
Should this also be absolute, like `_lookup_asset_url` returns?
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
```suggestion ``` Seems like this is already resolved.