Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ormsbee created a review comment on a pull request on openedx/edx-platform
You know, I think to date it returns a site-relative URL, but I think it makes more sense to return an absolute one, so I'll just do that and see if anything breaks. 😛
ormsbee created a review comment on a pull request on openedx/edx-platform
I'm kind of on the fence about it. When I took a brief sketch at extracting out the common part here, the helper naming and indirection just seemed to add more confusion than it was worth. I don't ...
bradenmacdonald created a comment on a pull request on openedx/edx-platform
> > 1. Is edx-platform the right place to add this module? (I think it is, because edx-search is used only in edx-platform). If yes, did I pick the right location in the edx-platform file hierarchy...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
Nit: I'd recommend moving this code and the code below into a new `_find_static_assets` method or something like that. Or use an explicit `else:` case. I'm just worried that someone might not noti...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
Should this also be absolute, like `_lookup_asset_url` returns?
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
```suggestion ``` Seems like this is already resolved.
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
```suggestion The standard XBlock "static/{asset_path}" substitution strips out the ```
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
Do you think it makes sense to combine this with the similar logic in `get_block()`? https://github.com/openedx/edx-platform/blob/ecbedbcf78cd74c907f18d76b77a64e31ccf78fe/openedx/core/djangoapps...
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
Nit: we're moving toward `local.openedx.io` so I'd recommend just using that in all docs going forward. e.g. the new [`npm run dev` command](https://github.com/openedx/frontend-app-authoring?tab=re...
bradenmacdonald created a review on a pull request on openedx/edx-platform
Seems to be working well with the test content I have :)
bradenmacdonald created a review on a pull request on openedx/edx-platform
Seems to be working well with the test content I have :)
GlugovGrGlib created a review comment on a pull request on openedx/edx-platform
Nice catch, definitely agree rename is necessary in this case.
ormsbee opened a pull request on openedx/edx-platform
Enable static assets in Learning Core XBlock Runtime
## Description This enable the viewing of static assets in the Learning Core XBlock Runtime. It is version aware, so calling the XBlock iframe with different versions will properly reflect the rig...
kdmccormick created a review comment on a pull request on openedx/edx-platform
@KyryloKireiev Thanks for that background. ### Pagination/limits In order to keep large Open edX sites safe from DDOS attacks, all HTTP APIs need to be paginated (with a max page size) or li...
kdmccormick created a review on a pull request on openedx/edx-platform
Thank you for the helpful Google doc, and thank you for your patience.
kdmccormick created a review on a pull request on openedx/edx-platform
Thank you for the helpful Google doc, and thank you for your patience.
bmtcril pushed 1 commit to bmtcril/retirement_extension_docs openedx/edx-platform
- docs: Update retirement docs Add some details around extending retirement steps e848c78
edx-secure pushed 1 commit to 2u/release openedx/edx-platform
- feat: Upgrade Python dependency edx-enterprise 4.28.0 | Introduce default enrollment models Commit generated by wor... ecbedbc
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX production environment.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX production environment.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX production environment.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX production environment.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX production environment.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX production environment.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX staging environment in preparation for a release to production.