Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
bradenmacdonald pushed 1 commit to braden/block-draft-published openedx/edx-platform
- docs: address review comments d79d43f
bradenmacdonald created a comment on a pull request on openedx/edx-platform
@kdmccormick We don't need to support `api.create_library_block_for_child` since we aren't going to support child blocks in libraries at all AFAIK.
kdmccormick created a review comment on a pull request on openedx/edx-platform
```suggestion usage_key = video_block.usage_key ``` [nit] you can use the shorthand now if you'd like
kdmccormick created a review comment on a pull request on openedx/edx-platform
Would it be fair to delete this Historic Information or update it for Learning Core?
kdmccormick created a review comment on a pull request on openedx/edx-platform
This is the [Django view implemenation of the asset server](https://github.com/openedx/openedx-learning/blob/main/docs/decisions/0015-serving-static-assets.rst#django-view-implemenation), but just ...
kdmccormick created a review comment on a pull request on openedx/edx-platform
Just checking my understanding: you mean that we won't run this at _LMS_ scale, right? If I understand right, large sites' CMS servers will still hit this view when serving content library assets f...
kdmccormick created a review comment on a pull request on openedx/edx-platform
If this should only be used by CMS, it might be good to enforce that? I would love if the library API URLs just weren't defined for LMS, but without taking on all of that work, you could just: ...
bradenmacdonald created a comment on a pull request on openedx/edx-platform
@kdmccormick Thanks! Here is the corresponding ticket for the UI: https://github.com/openedx/frontend-app-authoring/issues/1385
ormsbee created a review comment on a pull request on openedx/edx-platform
@bradenmacdonald: Okay, I think that's fine. And if it becomes a problem, we can address it then. No need to re-review on my part. Thank you!
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
@ormsbee Please let me know if that makes sense ^ and if you wanna take another look at this PR before I merge.
edx-secure pushed 1 commit to 2u/release openedx/edx-platform
- feat!: Remove outdated Libraries Relaunch cruft (#35644) The V2 libraries project had a few past iterations which we... 2bbd8ec
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX production environment.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX production environment.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX staging environment in preparation for a release to production.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX staging environment in preparation for a release to production.
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
I know. But generally if you're loading a specific version, I assume you're not planning to make changes. If you were planning to make changes, you'd always want to load LatestVersion.DRAFT to avoi...
kdmccormick created a review comment on a pull request on openedx/edx-platform
@ormsbee Note that I've gone an implemented `sever_upstream_link` (and its matching HTTP API, `DELETE /api/contentstore/v2/downstream/{key}`. It's not needed for the MVP, but it was easy enough to ...
kdmccormick created a review comment on a pull request on openedx/edx-platform
Great idea. Done, in my latest commit.
kdmccormick created a comment on a pull request on openedx/edx-platform
@ormsbee Ready for another pass
kdmccormick created a review comment on a pull request on openedx/edx-platform
Yeah, I'm thinking about that now over in this PR: https://github.com/openedx/edx-platform/pull/35553 I might end up mixing it into the LMS too, but I'll leave this here for now.
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[question] Do we need this comments?
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[nit] Let's include in the block below: ``` body { #openassessment-editor { #openassessment_editor_header, .openassessment_tab_instructions { background-colo...
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[question] Can we use existing variables or create new variables for colors instead of hardcoding them?
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[nit] Can be simplified ``` input:not([type="radio"], [type="checkbox"], [type="submit"]) { ```