Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
@ormsbee Please let me know if that makes sense ^ and if you wanna take another look at this PR before I merge.
edx-secure pushed 1 commit to 2u/release openedx/edx-platform
- feat!: Remove outdated Libraries Relaunch cruft (#35644) The V2 libraries project had a few past iterations which we... 2bbd8ec
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX production environment.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX production environment.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX staging environment in preparation for a release to production.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX staging environment in preparation for a release to production.
bradenmacdonald created a review comment on a pull request on openedx/edx-platform
I know. But generally if you're loading a specific version, I assume you're not planning to make changes. If you were planning to make changes, you'd always want to load LatestVersion.DRAFT to avoi...
kdmccormick created a review comment on a pull request on openedx/edx-platform
@ormsbee Note that I've gone an implemented `sever_upstream_link` (and its matching HTTP API, `DELETE /api/contentstore/v2/downstream/{key}`. It's not needed for the MVP, but it was easy enough to ...
kdmccormick created a review comment on a pull request on openedx/edx-platform
Great idea. Done, in my latest commit.
kdmccormick created a comment on a pull request on openedx/edx-platform
@ormsbee Ready for another pass
kdmccormick created a review comment on a pull request on openedx/edx-platform
Yeah, I'm thinking about that now over in this PR: https://github.com/openedx/edx-platform/pull/35553 I might end up mixing it into the LMS too, but I'll leave this here for now.
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[question] Do we need this comments?
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[nit] Let's include in the block below: ``` body { #openassessment-editor { #openassessment_editor_header, .openassessment_tab_instructions { background-colo...
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[question] Can we use existing variables or create new variables for colors instead of hardcoding them?
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[nit] Can be simplified ``` input:not([type="radio"], [type="checkbox"], [type="submit"]) { ```
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[nit] Should be simplified to one `padding` rule. Also, we can stick to general rules for margin/paddings with using `$baseline` variable (ex: https://github.com/openedx/edx-platform/blob/2bbd8ecd...
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[nit] Let's declare all extended rules at the top of the block for separation and simple overriding.
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[nit] Should be simplified to one padding rule.
kdmccormick created a review comment on a pull request on openedx/edx-platform
I'm not sure yet. It might be good to straighten out `XBlock.editor_saved` and make it a proper XBlock API which we can rely upon here.
ormsbee created a comment on a pull request on openedx/edx-platform
@Ian2012: Transcripts are somewhat tested in the static assets test case that I [re-enabled](https://github.com/openedx/edx-platform/pull/35639/files#diff-40d2d6f200231325540b59202ae71fd10ca5741178...
kdmccormick created a review comment on a pull request on openedx/edx-platform
Will do in a follow-up
kdmccormick created a review comment on a pull request on openedx/edx-platform
Based on [these changes](https://github.com/openedx/edx-platform/pull/34925#discussion_r1801586472), I was able to make `get_for_block` return `UpstreamLink` (non-nullable), which made this type-ig...