Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[nit] Should be simplified to one `padding` rule. Also, we can stick to general rules for margin/paddings with using `$baseline` variable (ex: https://github.com/openedx/edx-platform/blob/2bbd8ecd...
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[nit] Let's declare all extended rules at the top of the block for separation and simple overriding.
ihor-romaniuk created a review comment on a pull request on openedx/edx-platform
[nit] Should be simplified to one padding rule.
kdmccormick created a review comment on a pull request on openedx/edx-platform
I'm not sure yet. It might be good to straighten out `XBlock.editor_saved` and make it a proper XBlock API which we can rely upon here.
ormsbee created a comment on a pull request on openedx/edx-platform
@Ian2012: Transcripts are somewhat tested in the static assets test case that I [re-enabled](https://github.com/openedx/edx-platform/pull/35639/files#diff-40d2d6f200231325540b59202ae71fd10ca5741178...
kdmccormick created a review comment on a pull request on openedx/edx-platform
Will do in a follow-up
kdmccormick created a review comment on a pull request on openedx/edx-platform
Based on [these changes](https://github.com/openedx/edx-platform/pull/34925#discussion_r1801586472), I was able to make `get_for_block` return `UpstreamLink` (non-nullable), which made this type-ig...
kdmccormick created a review comment on a pull request on openedx/edx-platform
Okay @ormsbee , I have pushed a new commit, which changes things a bit. 1. Blocks with no link (or a severed link): * In the data model, this is still represented as `block.upstream is None`...
edx-secure pushed 1 commit to 2u/release openedx/edx-platform
- feat: set collections for a library component [FC-0062] (#35600) * feat: add & remove collections to component C... 70df3de
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX production environment.
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX production environment.
kdmccormick created a review comment on a pull request on openedx/edx-platform
Good clal. In my latest commit, `try_get_for_block` now calls `logger.exception` with some extra details.
Ian2012 created a review on a pull request on openedx/edx-platform
LGTM, missing tests for the transcripts support. The conflicts are probably related to the version bump
Ian2012 created a review comment on a pull request on openedx/edx-platform
Do we need to add tests here?
edx-pipeline-bot created a comment on a pull request on openedx/edx-platform
**2U Release Notice**: This PR has been deployed to the edX staging environment in preparation for a release to production.
ormsbee created a comment on a pull request on openedx/edx-platform
Closing in favor of smaller PRs: * https://github.com/openedx/edx-platform/pull/35639
PKulkoRaccoonGang closed a draft pull request on openedx/edx-platform
DRAFT: Styles for course unit xblock elements
kdmccormick created a review comment on a pull request on openedx/edx-platform
@ormsbee AFAICT, we don't typically do additional logging for cut-and-dry 403/404 scenarios, so I'm not sure why we would here.
edx-secure created a branch on openedx/edx-platform
private_to_public_2bbd8ecd180f - The Open edX LMS & Studio, powering education sites around the world!