Ecosyste.ms: Timeline
Browse the timeline of over 8.09 Billion events for every public repo on GitHub, all the way back to 2015. Data updated hourly from GH Archive.
ali-hosseini-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
it can be anything as the datasource is completely dynamic.
ali-hosseini-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
it can be anything as the datasource is completely dynamic.
ali-hosseini-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
this data source can be anything and we map it using keymapper function that should be passed to the component! so not sure how we can make a generic type for this.
ali-hosseini-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
as far as i checked it's implemented in other workspaces(packages) and there's no `Types` in Components workspace! Are you sure about this?
ali-hosseini-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
@maryia-deriv this `data_source` prop is a dynamic array and it depends on another prop from data-list component (Key mapper), basically it maps the data using keymapper function which is passed to...
maryia-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
@ali-hosseini-deriv please check what type of this row, it will be the same as row_obj🙂
maryia-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
@ali-hosseini-deriv we can figure out params and row types by checking how they are used in the code or what is passed.🙂
maryia-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
@ali-hosseini-deriv could you please declare a type for data_source array? data_source can be different but we have to declare its type to tell TS what properties it must have in order for DataList...
maryia-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
```suggestion root_store: TRootStore; ``` import { TRootStore } from '../types';
maryia-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
@ali-hosseini-deriv please check the type the row has. it's passed from DataList as data_source[index]🙂
niloofar-deriv pushed 25 commits to niloo/84471/ts-migration-parent niloofar-deriv/deriv-app
- Merge branch 'master' of github.com:binary-com/deriv-app 7e11b80
- Merge branch 'master' of github.com:binary-com/deriv-app e9293c4
- Amina/ fix: mf_list (#7516) * fix: mf_list * chore: trigger build b34a9e9
- Ameerul /Task 74218 Incorrect Deriv P2P Balance Information (#7491) * chore: added info icon and corrected informati... 0e84f9a
- Aizad/87647/open real dialog issue (#7504) * chore: fix sizing dialog for real account required on appstore * fix... 2b2357f
- 87814/fix blank onboarding for non en lang (#7527) * fix: exit traders hub * fix: exit v2 * fix: exit remove ... e1b715e
- Henry/86550/feat/change tabs to dropdown reports (#7443) * feat: change from tabs to dropdown menu in reports * f... a259f9a
- Sergei / 87513 / change create mt5 demo account congratulations text (#7496) * fix: change create mt5 deom account c... 7c047d7
- Shayan/80609/components shared ts migration parent (#7294) * checking circle/ci test * removed test changes * ... cb92eb4
- hamid/84403/add-mockStore-object-for-test-usage (#7440) * feat: add mockStore object for test usage * feat: use m... 266b228
- Hubert / fixing IDV validation (#7372) * chore: fixing IDV validation * chore: refactoring code --------- C... c54c71c
- fix: console error on edit ad where payment method is disabled from bo (#7427) bd4493b
- Kate/80001/Remove unused query params from the URL on initialize (#7447) * fix: add check for specific unused param... 60bf670
- Rostislav / 86373 / Bug fix for side note on cashier page going missing once we navigate to different tabs like Withd... 9db2dac
- Ameerul /Bug 86546 P2P clients (Not POI verified clients) are not temp. banned when we block temporary until 14th of ... 055373f
- Farzin/87456/Extract `is_onramp_tab_visible` method from cashier `OnRampStore` to reusable hook (#7475) * feat(core)... 3d1e7da
- chore: updated the readme file (#7388) * chore: updated the readme file * chore: updated readme * chore: updat... 5e0a043
- hamid/86888/refactor-hook-test-files-to-use-testing-library-react-hooks (#7448) * feat: enhance the tests with react... 34d6345
- fix: issue with payment method search filter (#7426) * fix: issue with payment method search filter * fix: no sea... 490ecb5
- Merge branch 'master' of github.com:binary-com/deriv-app 8b6c7c8
- and 5 more ...
maryia-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
```suggestion passthrough?: { isTopUp: (item: { action: string } ) => boolean }; ```
ali-hosseini-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
i removed it
ali-hosseini-deriv created a review comment on a pull request on niloofar-deriv/deriv-app
the return type would be undefined in some of the cases and not the measure it self