Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
asteny created a review comment on a pull request on nebius/soperator
So, what will be if user write #PartirionName=..? Next question: where is better place for fail? In operator (here you need read logs of operator in order to understand what happen and where is a...
dstaroff created a review comment on a pull request on nebius/soperator
It gives: - You won't need `scanner` anymore - As simple as `for range` loop - Line processing becomes more clear - You can just add comment lines between config strings to separate blocks ...
rdjjke created a review comment on a pull request on nebius/soperator
OK, but what if the user writes "PartirionName=..." (with a mistake) -- this line will be ignored.
dstaroff created a review comment on a pull request on nebius/soperator
Maybe it is better to have it as `[]string` instead of multi-line string?
asteny created a review comment on a pull request on nebius/soperator
You wrote exactly that I did in code) Why we should fail? We wrote example that config lines should have PartionName in the start of the line. And only them we get from config. How you want val...
rdjjke created a review comment on a pull request on nebius/soperator
Why there is no validation anymore? I think the logic should be such: - Lines that start with "PartitionName" are partition configuration that is inserted into the slurm.conf - Empty lines, li...
asteny created a review comment on a pull request on nebius/soperator
Changed. Now only if string started with PartitionName we will put it in config
asteny pushed 1 commit to partitions nebius/soperator
- change example for partitions and parse only string started with PartitionName 42746ff
asteny created a review comment on a pull request on nebius/soperator
But that's example of not default config) If configType - default doesn't matter what u will put on rawConfig. Ok I'll change comment here: `Example for custom ConfigType`
rdjjke created a review comment on a pull request on nebius/soperator
Because this is an example of the "default" config. I expect a name like "default" or "main" (we have "main" now while it's not configurable)
asteny created a review comment on a pull request on nebius/soperator
Because in this example u have 2 partitions hi and low, and by default u will use low. Which names do u want see here?
rdjjke created a review comment on a pull request on nebius/soperator
If the partition configuration is long, the user may want to split it into blocks separated by empty lines