Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ronso0 created a comment on a pull request on mixxxdj/mixxx
some thoughts on the general tooltip update approach used here and performance: With the current implementatoin kbd mapppings are (re)loaded * on startup * when kbd shortcuts are toggled on, a...
davidlmorris created a comment on a pull request on mixxxdj/mixxx
> Looking forward to see https://github.com/mixxxdj/mixxx/issues/13716. Have you seen https://github.com/mixxxdj/mixxx/pull/13750 yet (the PR for 13716)?
mxmilkiib created a comment on a pull request on mixxxdj/mixxx
Thanks for the feedback. I added the console output log, but indeed, that does sound about right. After the 4th loop, the loop counter has been ++ to 5, same with i to 17. Ah yes, the deck and i...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Rather just seeing if instead of a QByteArray the QJSValue returns an error using `QJSValue::isError`. Haven't tried that yet, but I'm fairly certain it should work.
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Using something like `try { } catch { }` is the JS code?
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
I think the problem is the mutability of the `deck` in line 155. try copying that into the handler closure on line 177.
christophehenry created a review comment on a pull request on mixxxdj/mixxx
I didn't know that C++ could do type conversion that powerful :thinking:
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
right, but `[Channel5]` must be coming from somewhere, you probably have an off-by-one error somewhere. Having a quick look at the gist however, I can't tell you where exactly. Try adding some logm...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
yeah, thats why `logMessagesExpected` is quite a hack...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I think it deduces that `{26, 26, 26, 26, 32, 26, 26, 26, 26}` is list-initialization of _some_ object type and then looks at the parameter, since `const char(&array)[size]` is an array literal, it...
mxmilkiib created a comment on a pull request on mixxxdj/mixxx
It doesn't, this is 4 decks, and whilst each deck has 32 or 36 or whatever hotcues, I'm only going up to 16. I get an error when I try to use .bind to bind the scope of the counter variables to th...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
well, in either way we would need to know exactly how the codec works so we can exploit the conversion process correctly. If the string from the user already contains the replacement character then...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
just put the hex in there if you prefer ;) ```suggestion ISO-8859-15 encoded 'Hello!' const char expected[] = {0x48, 0x65, 0x6c, 0x6c, 0x6f, 0x21}; ```
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
hardcoding the length is ugly (and error prone), lets change that. Add a utility (feel free to change the name): ```cpp template <int N> QByteArray intByteArray(const char(&array)[N]) { ret...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Is that an option in `QStringEncoder`? Couldn't spot any feature there. It may make sense to pass `QStringEncoder::Flag::ConvertInvalidToNull` along though.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
How exactly does it fail currently? I'd need to see some code to make a proper judgement.