Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
I think the problem is the mutability of the `deck` in line 155. try copying that into the handler closure on line 177.
christophehenry created a review comment on a pull request on mixxxdj/mixxx
I didn't know that C++ could do type conversion that powerful :thinking:
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
right, but `[Channel5]` must be coming from somewhere, you probably have an off-by-one error somewhere. Having a quick look at the gist however, I can't tell you where exactly. Try adding some logm...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
yeah, thats why `logMessagesExpected` is quite a hack...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I think it deduces that `{26, 26, 26, 26, 32, 26, 26, 26, 26}` is list-initialization of _some_ object type and then looks at the parameter, since `const char(&array)[size]` is an array literal, it...
mxmilkiib created a comment on a pull request on mixxxdj/mixxx
It doesn't, this is 4 decks, and whilst each deck has 32 or 36 or whatever hotcues, I'm only going up to 16. I get an error when I try to use .bind to bind the scope of the counter variables to th...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
well, in either way we would need to know exactly how the codec works so we can exploit the conversion process correctly. If the string from the user already contains the replacement character then...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
just put the hex in there if you prefer ;) ```suggestion ISO-8859-15 encoded 'Hello!' const char expected[] = {0x48, 0x65, 0x6c, 0x6c, 0x6f, 0x21}; ```
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
hardcoding the length is ugly (and error prone), lets change that. Add a utility (feel free to change the name): ```cpp template <int N> QByteArray intByteArray(const char(&array)[N]) { ret...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Is that an option in `QStringEncoder`? Couldn't spot any feature there. It may make sense to pass `QStringEncoder::Flag::ConvertInvalidToNull` along though.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
How exactly does it fail currently? I'd need to see some code to make a proper judgement.
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Hmm… Now I'm thinking… Should it try to remove diacritics for charsets like Latin-1 that don't support accents? Should it be an option?
ronso0 created a review comment on a pull request on mixxxdj/mixxx
...and now (without the debug stuff) it's obvious that the extra controls do have a noticeable impact: with: 4-5ms without: ~2.5ms
acolombier created a review comment on a pull request on mixxxdj/mixxx
No UI there yet, to be reviewed in #13670
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
I think you're getting quite far. the problem now is likely that there is no `[Channel5]` created so it can't access a hotcue there. What skin are you using? You can can use the developer tools to ...
heldderarbeit created a comment on an issue on mixxxdj/mixxx
The complete mixxx.log file: https://pastebin.com/raw/EzkYeW5v Now trying to debug with gdb according to https://github.com/mixxxdj/mixxx/issues/11464#issuecomment-1507945048: https://pastebin.c...
daschuer created a review comment on a pull request on mixxxdj/mixxx
```suggestion << tr("Decrement the bar length by one beat between adjacent markers."); ```
daschuer created a review comment on a pull request on mixxxdj/mixxx
```suggestion << tr("When tapped, decrease the BPM between adjacent markers around the " ``` Here we have also the padding bar issue. Probably spit the right marker visyally and crea...