Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Like: ```c++ VERIFY_OR_DEBUG_ASSERT(…) { } jsEngine()->throwError() ``` ?
mxmilkiib created a comment on a pull request on mixxxdj/mixxx
I've got [this](url) currently, but now the pads aren't even lighting up.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
for `enum class` I prefer `CamelCase` (also looks nicer in JS). I don't know how to express the ISO names well, so I guess the current naming is fine. ```suggestion Latin1, ISO_8...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
this is not common in C++ and some devs even frown upon it. ```suggestion return convertCharset(QStringLiteral("ISO-8859-1"), value); ```
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
of course `qjsvalue_cast`, very elegant! :+1:
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I think the implicit `toString` cast is wrong I think (and likely also the cause for the failing test). ```suggestion const auto result = evaluate( "engine.convertCharset(engine....
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I think we also want logoutput here and/or throw an error. wdyt?
ronso0 opened a draft pull request on mixxxdj/mixxx
DEBUG kbd mapping: umlauts slip through when hit while editable table cell is focused
This adds some logging in order to debug [Keyboard shortcut “ö” stopped working (other umlauts affected, too)](https://mixxx.discourse.group/t/keyboard-shortcut-o-stopped-working-other-umlauts-aff...
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
Potentially slightly different includes depending on the platform and/or you're using a different Qt version, so the `#if` directives evaluate differently (that is usually one of the reason why its...
christophehenry created a comment on a pull request on mixxxdj/mixxx
What wait? Why don't I need it here, locally?
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
I think you're simply missing the `#include <QStringEncoder>`
christophehenry created a comment on a pull request on mixxxdj/mixxx
Ok, I reverted my changes and applied your suggestions. Now let's look at these failing build on macOS…
uklotzde created a review comment on a pull request on mixxxdj/mixxx
That doesn't look correct to me. The brittle _max index_ = _size minus one_ semantics are error prone. `maxFieldIndex()` should better become `endFieldIndex()` which would be more consistent ...
github-actions[bot] created a comment on a pull request on mixxxdj/mixxx
This PR is marked as stale because it has been open 90 days with no activity.
mr-smidge created a comment on a pull request on mixxxdj/mixxx
> BTW: Engine 4.1 was published today. DigitalDjTips write about it: "the software uses an updated database, it’s not backwards compatible with 4.0 databases." Great timing! :confounded:
JoergAtGithub created a comment on a pull request on mixxxdj/mixxx
BTW: Engine 4.1 was published today. DigitalDjTips write about it: "the software uses an updated database, it’s not backwards compatible with 4.0 databases."
Holzhaus created a comment on an issue on mixxxdj/mixxx
Sounds like it caused by slow I/O. That would also explain why it's faster on subsequent Mixxx stats, because then the data has already been loaded in memory buffers. HDDs are slow, but usually no...
leo-combes opened an issue on mixxxdj/mixxx
mixxx takes too long to start up
### Bug Description I've been using Mixxx 2.3.1 without any problems for a long time on Linux Mint 19. A couple of weeks ago I decided to try the new version and for that I installed the latest ve...
dependabot[bot] deleted a branch mixxxdj/mixxx
dependabot/github_actions/coverallsapp/github-action-2.3.3
ronso0 pushed 2 commits to main mixxxdj/mixxx
ronso0 closed a pull request on mixxxdj/mixxx
Bump coverallsapp/github-action from 2.3.1 to 2.3.3
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.1 to 2.3.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/cov...
dependabot[bot] opened a pull request on mixxxdj/mixxx
Bump coverallsapp/github-action from 2.3.1 to 2.3.3
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.1 to 2.3.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/cov...
dependabot[bot] created a branch on mixxxdj/mixxx
dependabot/github_actions/coverallsapp/github-action-2.3.3 - Mixxx is Free DJ software that gives you everything you need to perform live mixes.