Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Ok. I won't stress this for now then. Lets focus on the other stuff first.
Swiftb0y created a review on a pull request on mixxxdj/mixxx
LGTM. Thank you for the cleanup. Please rebase.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
yeah I'm just worried about forgetting about it. But you're right, lets postpone for now.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
makes sense. It was more of a general question whether this would be needed in production code.
daschuer created a review comment on a pull request on mixxxdj/mixxx
> I'm also not sure what the semantics are when the enum suddenly gets different values That is the great thing with this "feature". Compiling fails. So you cannot mess up the initalization you...
acolombier created a review comment on a pull request on mixxxdj/mixxx
It will probably work, but I preferred to make it explicit so if something was to crash when deallocating the screen, it still happens as part of the test hooks
daschuer closed a pull request on mixxxdj/mixxx
libdjinterop 0.22.1, support for Engine 4.0.1
Latest version of libdjinterop adds support for Engine 4.0.0/4.0.1. Fixes #13695
daschuer pushed 3 commits to 2.4 mixxxdj/mixxx
ronso0 pushed 50 commits to 2.4 mixxxdj/mixxx
- Add mappings for Reloop Mixage 06503c9
- Fix ESlint problems 572a07d
- Newline at the end of the file e7e23ab
- Add channel 2 hotcue buttons 73213dc
- Refactor VU meter updates 9fbb173
- Make scratch by touch option actually work 8242c52
- Apply some suggestions from code review Co-authored-by: Swiftb0y <[email protected]> b101dcc
- Fix unused parameter syntax afc62df
- Add user setting to turn on library auto-maximizing (default off) a51be5e
- Use makeConnection instead of connectControl efc42b9
- Make timeouts user-configurable 1a4c71f
- Enable LOAD LED as a warning when deck is playing 632d69e
- Add dummy array entry to improve code readability 1f82e84
- Completely rework scratching aa9922c
- Restore deck effect states 213132a
- Remap MASTER button, but disable until Mixxx function is working d2706fd
- Fix linter issues 549361b
- Add function to scroll through side pane using track select knob 4117890
- Fix scratching / scrolling. Make scratch and scroll speed user-adjustable. Map PAN button. Refactor rotatry button pr... ff6c8f3
- Initial commit 27d63f2
- and 30 more ...
ronso0 closed a pull request on mixxxdj/mixxx
Reloop Mixage MK1, MK2, Controller Edition mappings for Mixxx 2.4
Much improved and cleaned up version of PR #10892 by @gqzomer (Gersom Zomer) using Mixxx 2.4 functions like effect presets. Documentation in a new manual PR here [#592](https://github.com/mixxxdj/m...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I think in order to truly benefit from resource safety here, the unique_ptr wrapping needs to be done on the return value of `qmlComponent.createWithInitialProperties` (directly in the same stateme...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
does it work without the explicit `.clear()`? Ideally RAII would take care of this fully by itself.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
ah yeah, I think my knowledge on `unordered_map` is not quite good enough to make an educated decision here. Keep as is for now.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
yup, pretty much exactly. thanks.
acolombier created a review comment on a pull request on mixxxdj/mixxx
Makes sense. I have rework it to use a single lookup. Hopefully this works as you had it in mind.
acolombier created a review comment on a pull request on mixxxdj/mixxx
Ah good to know! I thought `unique_ptr` were pretty safe when it come to leakge protection, but great to learn they can still s**** you :sweat_smile: In the context of unittest, a memory allocat...