Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
daschuer closed a pull request on mixxxdj/mixxx
libdjinterop 0.22.1, support for Engine 4.0.1
Latest version of libdjinterop adds support for Engine 4.0.0/4.0.1. Fixes #13695
daschuer pushed 3 commits to 2.4 mixxxdj/mixxx
ronso0 pushed 50 commits to 2.4 mixxxdj/mixxx
- Add mappings for Reloop Mixage 06503c9
- Fix ESlint problems 572a07d
- Newline at the end of the file e7e23ab
- Add channel 2 hotcue buttons 73213dc
- Refactor VU meter updates 9fbb173
- Make scratch by touch option actually work 8242c52
- Apply some suggestions from code review Co-authored-by: Swiftb0y <[email protected]> b101dcc
- Fix unused parameter syntax afc62df
- Add user setting to turn on library auto-maximizing (default off) a51be5e
- Use makeConnection instead of connectControl efc42b9
- Make timeouts user-configurable 1a4c71f
- Enable LOAD LED as a warning when deck is playing 632d69e
- Add dummy array entry to improve code readability 1f82e84
- Completely rework scratching aa9922c
- Restore deck effect states 213132a
- Remap MASTER button, but disable until Mixxx function is working d2706fd
- Fix linter issues 549361b
- Add function to scroll through side pane using track select knob 4117890
- Fix scratching / scrolling. Make scratch and scroll speed user-adjustable. Map PAN button. Refactor rotatry button pr... ff6c8f3
- Initial commit 27d63f2
- and 30 more ...
ronso0 closed a pull request on mixxxdj/mixxx
Reloop Mixage MK1, MK2, Controller Edition mappings for Mixxx 2.4
Much improved and cleaned up version of PR #10892 by @gqzomer (Gersom Zomer) using Mixxx 2.4 functions like effect presets. Documentation in a new manual PR here [#592](https://github.com/mixxxdj/m...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I think in order to truly benefit from resource safety here, the unique_ptr wrapping needs to be done on the return value of `qmlComponent.createWithInitialProperties` (directly in the same stateme...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
does it work without the explicit `.clear()`? Ideally RAII would take care of this fully by itself.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
ah yeah, I think my knowledge on `unordered_map` is not quite good enough to make an educated decision here. Keep as is for now.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
yup, pretty much exactly. thanks.
acolombier created a review comment on a pull request on mixxxdj/mixxx
Makes sense. I have rework it to use a single lookup. Hopefully this works as you had it in mind.
acolombier created a review comment on a pull request on mixxxdj/mixxx
Ah good to know! I thought `unique_ptr` were pretty safe when it come to leakge protection, but great to learn they can still s**** you :sweat_smile: In the context of unittest, a memory allocat...
ronso0 created a comment on an issue on mixxxdj/mixxx
> Also (re)enabling "Assume constant tempo" for a single track in its properties is ignored unless the BPM also has been edited manually. Yes, the UX with this option should be improved. The ch...
Holzhaus created a comment on a pull request on mixxxdj/mixxx
I rebased again because the PR checks didn't run for some reason.
ronso0 created a comment on an issue on mixxxdj/mixxx
When I try to reproduce I see these warning being logged ```c++ warning [Main] Marker with 117 beats till next marker cannot be scaled by 0.75 warning [Main] Marker with 67 beats till next marke...
ronso0 created a comment on a pull request on mixxxdj/mixxx
I only tried to make some sugestions to improve the workflow. I think @Swiftb0y was reviewing the code.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I currently don't have the time to give this yet another proper review. Please consult with @daschuer on the next steps.
davidlmorris created a review comment on a pull request on mixxxdj/mixxx
Yeah, I've read some Uncle Bob stuff. I should check out his book(s?). What I liked about Steve's work was it was so concrete (practical), and backed up by evidence. So to the matter at hand. ...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Ah right. Well the `contains`+`at` pattern is suboptimal because you do two lookups instead of one. It'd be nice if you could switch these around to only use one `find`.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Thank you for your recommendation. I've studied some of Robert C. Martins books so far but "Code Complete" also seems interesting. I will try to get a hold of a copy.