Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ronso0 created a comment on an issue on mixxxdj/mixxx
> Also (re)enabling "Assume constant tempo" for a single track in its properties is ignored unless the BPM also has been edited manually. Yes, the UX with this option should be improved. The ch...
Holzhaus created a comment on a pull request on mixxxdj/mixxx
I rebased again because the PR checks didn't run for some reason.
ronso0 created a comment on an issue on mixxxdj/mixxx
When I try to reproduce I see these warning being logged ```c++ warning [Main] Marker with 117 beats till next marker cannot be scaled by 0.75 warning [Main] Marker with 67 beats till next marke...
ronso0 created a comment on a pull request on mixxxdj/mixxx
I only tried to make some sugestions to improve the workflow. I think @Swiftb0y was reviewing the code.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I currently don't have the time to give this yet another proper review. Please consult with @daschuer on the next steps.
davidlmorris created a review comment on a pull request on mixxxdj/mixxx
Yeah, I've read some Uncle Bob stuff. I should check out his book(s?). What I liked about Steve's work was it was so concrete (practical), and backed up by evidence. So to the matter at hand. ...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Ah right. Well the `contains`+`at` pattern is suboptimal because you do two lookups instead of one. It'd be nice if you could switch these around to only use one `find`.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Thank you for your recommendation. I've studied some of Robert C. Martins books so far but "Code Complete" also seems interesting. I will try to get a hold of a copy.
Ashankan created a comment on an issue on mixxxdj/mixxx
"The Internal Clock should not be given any new sources of bpm clock. If someone wants to write a Midi Clock source, it should be a separate Syncable object that can become leader" If the inter...
christophehenry created a comment on a pull request on mixxxdj/mixxx
This is an alternative to registering MIDI handler from XML. Itks a implementation of https://github.com/mixxxdj/mixxx/wiki/Registering-Midi-Input-Handlers-From-Javascript
daschuer created a comment on an issue on mixxxdj/mixxx
A first step would be to expose the CO `[InternalClock],bpm` in a skin.
daschuer created a comment on an issue on mixxxdj/mixxx
We have that already on the hood, but have not yet exposed it to the user: https://github.com/mixxxdj/mixxx/blob/fe9608f80f1cdb031a07fb1acc930899c5e93434/src/engine/sync/internalclock.h#L17 At ...
davidlmorris created a review comment on a pull request on mixxxdj/mixxx
You are technically correct. As I remember it at the time Prolog was considered to be like a functional language... and the way it works has similarities at least. Haskal was a thing. There was a...
acolombier opened an issue on mixxxdj/mixxx
CLI argument `--log-level debug` shows controller debug messages
### Bug Description If `--log-level` is set to `debug`, Mixxx will log controller related debug message. These messages are supposed to be logged only if `--controller-debug` is passed, but this l...
acolombier created a review comment on a pull request on mixxxdj/mixxx
What is the gain here? Also, please not that this is a test file so macro optimisation is unnecessary.
acolombier created a review comment on a pull request on mixxxdj/mixxx
Line 509, there is already an assertin for the string to be in the map
m0dB created a review comment on a pull request on mixxxdj/mixxx
Yes, I will try to split it in multiple PRs, but a lot of the commits are not relevant anymore, so I will first squash and then create some new PRs with parts of the code.
daschuer created a comment on an issue on mixxxdj/mixxx
I don't mind which solution we pick. It is finally a question how easy and risky a logic change is. For my understanding the issue is only to fix a new more strict and valid warning in code tha...
mxmilkiib created a comment on a pull request on mixxxdj/mixxx
Would this be a method for [re]connecting pad MIDI presses like in [this instance](https://mixxx.discourse.group/t/launchpad-pro-mk3-basic-4x16-hotcue-setup-troubles/29701/10?u=milkii)? I had assum...
